Fix: Graph deleted before aptly exits #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reglim
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
6 times, most recently
from
8655777 to
7192f1e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
+ Coverage 74.81% 75.12% +0.30%
==========================================
Files 157 157
Lines 18180 18172 -8
==========================================
+ Hits 13602 13651 +49
+ Misses 3470 3404 -66
- Partials 1108 1117 +9 ☔ View full report in Codecov by Sentry. |
randombenj
approved these changes
Sep 15, 2023
reglim
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
7192f1e to
486e864
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
2ee09ab to
33fe7de
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
33fe7de to
cc3403f
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
cc3403f to
8a44c89
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
2 times, most recently
from
bf34f8a to
9cb754a
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
9cb754a to
be893e5
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
be893e5 to
446ada5
Compare
iofq
approved these changes
Nov 17, 2024
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
446ada5 to
0d28427
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
2 times, most recently
from
4be2935 to
3a7de07
Compare
neolynx
added
needs review
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
3 times, most recently
from
ff7797e to
b64067f
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
b64067f to
320307f
Compare
|
rewrite of original PR, instead of a timeout and removing the tmp file, just leave it to the user or system to clean it up. |
szakalboss
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1213
Description of the Change
A viewer might reload/monitor the image file, therefore aptly should not remove the temporary image file.
As the tempfile is created in /tmp, it should be cleanedup automatically or by the user.