Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix system tests #1265

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix system tests #1265

merged 2 commits into from
Apr 11, 2024

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Apr 10, 2024

Description of the Change

  • use s3 mirror instead of internet download
  • reduce download verbosity
  • do not use venv in docker-system-tests
  • be more verbose on test output
  • do not run golangci-lint in system-tests

@neolynx neolynx self-assigned this Apr 10, 2024
@neolynx neolynx requested review from mfolusiak, szakalboss and a team April 10, 2024 21:05
- use s3 mirror instead of internet download
- reduce download verbosity
- do not use venv in docker-system-tests
- be more verbose on test output
- do not run golangci-lint in system-tests
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.70%. Comparing base (50eaf6c) to head (9d9dda7).
Report is 5 commits behind head on master.

Files Patch % Lines
http/download.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
- Coverage   74.78%   74.70%   -0.08%     
==========================================
  Files         143      144       +1     
  Lines       16200    16221      +21     
==========================================
+ Hits        12115    12118       +3     
- Misses       3148     3159      +11     
- Partials      937      944       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx merged commit 32595e7 into master Apr 11, 2024
5 checks passed
@neolynx neolynx deleted the fix/system-tests branch April 11, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants