Let people set custom labels for metrics #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banool
force-pushed
the
banool/custom-lable
branch
3 times, most recently
from
a6f0de3 to
e7c022e
Compare
banool
force-pushed
the
banool/custom-lable
branch
from
e7c022e to
10ed0f2
Compare
just-in-chang
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Being able to set custom labels is necessary for some of the alarms I want to make.
i couldn't see a changelog to edit but this is technically a breaking change for people who build the config in code. Admittedly it's therefore a small breaking change since most people would just use a config file, in which case no change is required thanks to
#[serde(default)].Test Plan
CI