Update fa_coin and your_fungible_asset#600
Open
jmintuitive wants to merge 4 commits intoaptos-labs:mainfrom
Open
Update fa_coin and your_fungible_asset#600jmintuitive wants to merge 4 commits intoaptos-labs:mainfrom
jmintuitive wants to merge 4 commits intoaptos-labs:mainfrom
Conversation
3 tasks
gregnazario
approved these changes
Dec 18, 2024
Collaborator
gregnazario
left a comment
gregnazario
left a comment
There was a problem hiding this comment.
LGTM, just clean up those two issues
| * @param admin - The account that deployed the fungible asset module. | ||
| * @returns The name of the token as a string. | ||
| */ | ||
| async function fetchTokenName(aptos: Aptos, admin: Account): Promise<string> { |
Collaborator
There was a problem hiding this comment.
These examples use a "global" aptos object, so it doesn't have to be passed here
|
|
||
| console.log( | ||
| "Alice as the admin forcefully transfers the newly minted coins of Charlie to Bob ignoring that Bob's account is frozen.", | ||
| `Alice as the admin forcefully transfers the newly minted coins of Charlie to Bob ignoring that Bob's account is frozen.`, |
Collaborator
There was a problem hiding this comment.
please replace with "
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the example code used in the "Your First Fungible Asset" tutorial in order to make it customizable. That way during the updated tutorial, you can change the name of the asset and see what the result is on-chain.
Test Plan
I tested locally to verify that the fa_coin still deployed and executed transactions correctly, but now the updated
your_fungible_assetscript actually looks up theASSET_NAME.Related Links
Checklist
pnpm fmt?CHANGELOG.md? (Not needed)