Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Nightly package dependency #246

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

0xmaayan
Copy link
Collaborator

Now that we have migrated to the new wallet adapter, a dapp doesnt need to hold a package depndency of a wallet that is compatible with the new standard

@0xmaayan 0xmaayan requested a review from a team as a code owner March 27, 2024 22:39
@0xmaayan 0xmaayan requested review from a team and removed request for a team March 27, 2024 22:39
@0xaptosj
Copy link
Contributor

does this mean dapp integrating wallet adaptor no longer need to add petra, okx, martian, etc. they only need to add wallet adaptor as dependency?

@0xmaayan
Copy link
Collaborator Author

does this mean dapp integrating wallet adaptor no longer need to add petra, okx, martian, etc. they only need to add wallet adaptor as dependency?

correct. as long as the wallet itself has migrated to the new standard

@0xmaayan 0xmaayan merged commit c8da908 into main Mar 27, 2024
6 checks passed
@0xmaayan 0xmaayan deleted the remove_nightly_dependency branch March 27, 2024 22:42
@0xaptosj
Copy link
Contributor

does this mean dapp integrating wallet adaptor no longer need to add petra, okx, martian, etc. they only need to add wallet adaptor as dependency?

correct. as long as the wallet itself has migrated to the new standard

wow nice, finally i dont need to have 10 wallets in dependency

@0xmaayan
Copy link
Collaborator Author

does this mean dapp integrating wallet adaptor no longer need to add petra, okx, martian, etc. they only need to add wallet adaptor as dependency?

correct. as long as the wallet itself has migrated to the new standard

wow nice, finally i dont need to have 10 wallets in dependency

YES!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants