Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GA4 #250

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Implement GA4 #250

merged 6 commits into from
Apr 12, 2024

Conversation

0xmaayan
Copy link
Collaborator

@0xmaayan 0xmaayan commented Apr 5, 2024

Adds support for Google Analytics 4 to track event in the wallet adapter.

@0xmaayan 0xmaayan requested a review from a team as a code owner April 5, 2024 18:23
@0xmaayan 0xmaayan changed the title [WIP] Implement GA4 Implement GA4 Apr 5, 2024
Copy link
Contributor

@BriungRi BriungRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these event recordings need to be wrapped in try/catch? I'm wondering if some of these requests will block or fail if the user has AdBlock enabled.

@0xmaayan
Copy link
Collaborator Author

0xmaayan commented Apr 8, 2024

Do these event recordings need to be wrapped in try/catch? I'm wondering if some of these requests will block or fail if the user has AdBlock enabled.

interesting... not sure. I could probably put recordEvent in a try/catch block

@0xmaayan
Copy link
Collaborator Author

0xmaayan commented Apr 9, 2024

Do these event recordings need to be wrapped in try/catch? I'm wondering if some of these requests will block or fail if the user has AdBlock enabled.

ok I tested it with an ad blocker (using Brave browser) and I dont think we need to use try/catch block as it doesnt break the app if blocker is on. I believe because it uses the window dataLayer object and does some background processes it doesnt affect the user

@0xmaayan 0xmaayan merged commit 41f9485 into main Apr 12, 2024
6 checks passed
@0xmaayan 0xmaayan deleted the ga4 branch April 12, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants