Upgrade to AIP-62 standard #464
Conversation
0xmaayan
force-pushed
the
aip_62_only
branch
4 times, most recently
from
b81b5f7 to
a79eab7
Compare
0xmaayan
changed the title
0xmaayan
requested review from
kaw2k,
hardsetting and
kent-white
as code owners
0xmaayan
force-pushed
the
aip_62_only
branch
2 times, most recently
from
b7898ef to
042eb70
Compare
| ).transaction.build.simple({ | ||
| sender: account.address, | ||
| data: { | ||
| function: "0x1::coin::transfer", | ||
| typeArguments: [APTOS_COIN], | ||
| functionArguments: [account.address, 1], // 1 is in Octas | ||
| functionArguments: [account.address.toString(), 1], // 1 is in Octas |
There was a problem hiding this comment.
not completely sure why it fails to send the account.address instance here
There was a problem hiding this comment.
mm good question. maybe AccountAddress from a different js bundle?
so instanceof AccountAddress returns false internally
There was a problem hiding this comment.
yes maybe, I thought that also. But both example and core use the same version, I'll test it again
There was a problem hiding this comment.
I tested, and made sure both packages use the same sdk version, still fails. It does not seem to be a sdk issue also. Everything is weird
| @@ -935,135 +714,100 @@ export class WalletCore extends EventEmitter<WalletCoreEvents> { | |||
| * @returns AccountAuthenticator | |||
| */ | |||
| async signTransaction( | |||
| transactionOrPayload: AnyRawTransaction | Types.TransactionPayload, | |||
| transactionOrPayload: AnyRawTransaction | InputTransactionData, | |||
There was a problem hiding this comment.
maybe split to 2 functions, one for JSON and one for Raw transaction input
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
0xmaayan
force-pushed
the
aip_62_only
branch
from
ee4cd0c to
d08f4e1
Compare
| // { | ||
| // label: "Min keys required", | ||
| // subLabel: "(only for multisig)", | ||
| // value: ( | ||
| // <p>{account?.minKeysRequired?.toString() ?? "Not Present"}</p> | ||
| // ), | ||
| // }, |
There was a problem hiding this comment.
Is this not working at the moment?
There was a problem hiding this comment.
No, the standard does not consider multi sig
| ).transaction.build.simple({ | ||
| sender: account.address, | ||
| data: { | ||
| function: "0x1::coin::transfer", | ||
| typeArguments: [APTOS_COIN], | ||
| functionArguments: [account.address, 1], // 1 is in Octas | ||
| functionArguments: [account.address.toString(), 1], // 1 is in Octas |
There was a problem hiding this comment.
mm good question. maybe AccountAddress from a different js bundle?
so instanceof AccountAddress returns false internally
0xmaayan
force-pushed
the
aip_62_only
branch
from
3563cc9 to
53eee94
Compare
0xmaayan
force-pushed
the
aip_62_only
branch
from
53eee94 to
ad886d2
Compare
This PR migrates the wallet adapter to support only the AIP-62 format and compatible wallets.
The AIP-62 standard is a chain-agnostic set of interfaces and conventions designed to enhance how applications interact with injected wallets. See more https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-62.md
By migrating to AIP-62, we can deprecate unmaintained or unused Aptos wallets, ensuring support is provided only for actively developed and functional wallets.
Additionally, dApps will be able to fetch and utilize wallet type information—a feature that has been highly requested by both the community and internal developers, see https://aptos-org.slack.com/archives/C06TWPH09Q9/p1721771598556349)
Live demo https://aptos-labs.github.io/aptos-wallet-adapter/nextjs-example-testing/