This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
feat(ec2): apply launch template to instance #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpivkin
force-pushed
the
launch-template
branch
from
909d682 to
f3d8877
Compare
nikpivkin
force-pushed
the
launch-template
branch
from
f3d8877 to
4d90647
Compare
simar7
reviewed
Jan 4, 2024
|
|
||
| resource "aws_instance" "this" { | ||
| launch_template { | ||
| name = aws_launch_template.this.name |
There was a problem hiding this comment.
what if name is not defined by the user?
There was a problem hiding this comment.
We generate the name as terrafrom does.
simar7
approved these changes
Jan 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close aquasecurity/trivy#5793
Launch templates define the configuration of ec2 instances, so we must apply them to instances when scanning the configuration.
Related PRs:
Ref: