fix: default accessGlobalSecretsAndServiceAccount to false#2942
Open
rzala wants to merge 1 commit intoaquasecurity:mainfrom
Open
fix: default accessGlobalSecretsAndServiceAccount to false#2942rzala wants to merge 1 commit intoaquasecurity:mainfrom
rzala wants to merge 1 commit intoaquasecurity:mainfrom
Conversation
Apply the principle of least privilege by disabling global secrets and service account access by default. When enabled, the operator gets cluster-wide RBAC permissions to create/get/update secrets, get serviceaccounts, and get nodes/proxy. Most deployments do not need these permissions unless pulling images from private registries. Users who need this for private registry access can explicitly set operator.accessGlobalSecretsAndServiceAccount=true. Updated across all locations: - Helm chart values.yaml and README.md - Go config default (envDefault) - Static deployment manifest - Configuration documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operator.accessGlobalSecretsAndServiceAccounttofalse(wastrue)operator.accessGlobalSecretsAndServiceAccount=trueChanges
deploy/helm/values.yaml— default changed tofalsedeploy/helm/README.md— updated default value in docs tablepkg/operator/etc/config.go—envDefaultchanged to"false"deploy/static/trivy-operator.yaml— static manifest default changeddocs/getting-started/installation/configuration.md— docs table updatedMotivation
When
accessGlobalSecretsAndServiceAccountistrue, the operator's ClusterRole includes permissions to create/get/update secrets and get serviceaccounts across all namespaces. This is only needed when vulnerability scan jobs need to pull images from private registries. Defaulting tofalsereduces the attack surface for the majority of deployments that don't require this.