Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to binary for msh #197

Merged
merged 1 commit into from
Dec 11, 2024
Merged

switch to binary for msh #197

merged 1 commit into from
Dec 11, 2024

Conversation

mohd-afeef-badri
Copy link
Collaborator

No description provided.

@mohd-afeef-badri
Copy link
Collaborator Author

@AlexlHer @grospelliergilles this PR needs Arcane version 3.14.14 but I guess the one for the CI is 3.14.13, is that the case why it is failing ?

@grospelliergilles
Copy link
Member

@AlexlHer @grospelliergilles this PR needs Arcane version 3.14.14 but I guess the one for the CI is 3.14.13, is that the case why it is failing ?

The version number has been increased to 3.14.14 on monday morning so it is not in the docker generated this week-end but the docker version has the wanted functionality. Anyway, we are regenerating the docker thanks to @AlexlHer so in one hour you should have the right version.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.69%. Comparing base (9fe36da) to head (943e806).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   70.69%   70.69%           
=======================================
  Files          56       56           
  Lines        8391     8391           
  Branches     1006     1006           
=======================================
  Hits         5932     5932           
  Misses       2176     2176           
  Partials      283      283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohd-afeef-badri
Copy link
Collaborator Author

Thank you so much @AlexlHer for updating the docker 👍🏻

@mohd-afeef-badri mohd-afeef-badri merged commit c063fc0 into main Dec 11, 2024
6 checks passed
@mohd-afeef-badri mohd-afeef-badri deleted the dev/mab-bin-for-msh branch January 6, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants