Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticity 3D #221

Merged
merged 9 commits into from
Feb 25, 2025
Merged

elasticity 3D #221

merged 9 commits into from
Feb 25, 2025

Conversation

mohd-afeef-badri
Copy link
Collaborator

No description provided.

add supporting operators needed for Real4
- Works for CPU, multi-CPU, GPU, multi-GPU
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 92.92929% with 21 lines in your changes missing coverage. Please review.

Project coverage is 75.21%. Comparing base (d9a629b) to head (2714527).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
modules/elasticity/FemModule.cc 86.86% 0 Missing and 13 partials ⚠️
femutils/BSRFormat.h 84.00% 1 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   74.88%   75.21%   +0.32%     
==========================================
  Files          64       64              
  Lines       10018    10230     +212     
  Branches     1200     1215      +15     
==========================================
+ Hits         7502     7694     +192     
- Misses       2157     2158       +1     
- Partials      359      378      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohd-afeef-badri mohd-afeef-badri added the enhancement New feature or request label Feb 21, 2025
Comment on lines 326 to 329
Int32 m_nb_non_zero_value;
Int32 m_nb_col;
Int32 m_nb_row;
Int8 m_nb_block;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields may be initialized to prevent errors if if we use the some methods of the class but initialize() has not yet been called.

Int32 m_nb_non_zero_value = 0;
Int32 m_nb_col = 0;
Int32 m_nb_row = 0;
Int8 m_nb_block = 1;

@@ -365,6 +366,7 @@ class BSRFormat : public TraceAccessor
/*---------------------------------------------------------------------------*/

private:
Int8 m_nb_dof;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Init with value 1.

@mohd-afeef-badri mohd-afeef-badri merged commit 743faa1 into main Feb 25, 2025
7 checks passed
@mohd-afeef-badri mohd-afeef-badri deleted the dev/mab-elasticity-3D branch February 25, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants