Add basic geometric partitioning for MSH parallel reader #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lelMeshReader'. Avant on partitionnait sur les uniqueId() des mailles mais dans GMSH la numérotation est assez quelconque et donc cela pouvait générer beaucoup de mailles fantômes. Pour éviter cela, on partitionne suivant la position des noeuds en prenant en compte uniquement la coordonnée X.
grospelliergilles
added
enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1138 +/- ##
==========================================
+ Coverage 72.21% 72.22% +0.01%
==========================================
Files 2019 2019
Lines 147914 147993 +79
==========================================
+ Hits 106813 106886 +73
- Misses 41101 41107 +6 ☔ View full report in Codecov by Sentry. |
grospelliergilles
deleted the
dev/gg-add-basic-coordinate-partition-for-msh-parallel-reader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because partitioning based on cells unique id does not work well.
Cells with consecutive unique id are anywhere in the mesh which results in a lot of ghost cells before the first partitioning.
Using a simple partitioning based on the X coordinates of the nodes lead to a better balancing.