Skip to content

Set by default 'CMAKE_BUILD_TYPE' to 'Release' only if 'ARCCORE_BUILD_MODE' is not defined #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

grospelliergilles
Copy link
Member

No description provided.

@grospelliergilles grospelliergilles added the build Build configuration label Jan 31, 2024
@grospelliergilles grospelliergilles self-assigned this Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (521192a) 72.23% compared to head (d47507e) 72.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
- Coverage   72.23%   72.22%   -0.01%     
==========================================
  Files        2026     2026              
  Lines      148082   148084       +2     
==========================================
- Hits       106964   106961       -3     
- Misses      41118    41123       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit dc2b287 into main Jan 31, 2024
@grospelliergilles grospelliergilles deleted the dev/gg-use-release-only-if-arccore-build-mode-not-specified branch February 3, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant