Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify method 'ItemMaterialVariableBase::_initializeNewItems()' and cleanup code #1738

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

grospelliergilles
Copy link
Member

No description provided.

…wItems()'

En profite pour corriger des avertissements signalés par 'clang-tidy'.
@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup arcane:materials Management of Constituents (Material/Environment) labels Nov 7, 2024
@grospelliergilles grospelliergilles self-assigned this Nov 7, 2024
@grospelliergilles grospelliergilles merged commit 67e8aae into main Nov 7, 2024
27 checks passed
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.29%. Comparing base (35ea18f) to head (2b31b61).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...e/src/arcane/materials/ItemMaterialVariableBaseT.H 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1738      +/-   ##
==========================================
- Coverage   70.29%   70.29%   -0.01%     
==========================================
  Files        2257     2257              
  Lines      161822   161822              
  Branches    18651    18651              
==========================================
- Hits       113748   113745       -3     
- Misses      41322    41324       +2     
- Partials     6752     6753       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles deleted the dev/gg-simplify-initialize-new-items branch November 11, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane:materials Management of Constituents (Material/Environment) arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant