Fix bug in 'CellFamily::_addChildCellToCell()' when added child cell is not the last #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lorsque la maille ajoutée n'est pas la dernière. Avant cette modification la méthode ne fonctionnait que si la maille enfant ajoutée était la dernière. Avec l'équilibrage de charge ce ne sera pas forcément le cas.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1782 +/- ##
==========================================
+ Coverage 70.25% 70.26% +0.01%
==========================================
Files 2258 2258
Lines 162280 162287 +7
Branches 18695 18695
==========================================
+ Hits 114003 114039 +36
+ Misses 41505 41478 -27
+ Partials 6772 6770 -2 ☔ View full report in Codecov by Sentry. |
stdcm
approved these changes
Nov 25, 2024
grospelliergilles
deleted the
dev/gg-fix-potential-error-in-when-adding-child-cell
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.