Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Arccore configuration #1786

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

grospelliergilles
Copy link
Member

  • Add target Threads::Threads for arccore_concurrency
  • Allow adding explicit target for arccore_message_passing_mpi.

…e_concurrency'.

This is needed to make sure libraries needed for threads are linked.
…core_message_passing_mpi'.

This will be used for example to add libraries to handle specific features
like GPU aware. This is needed with Cray Mpich.
@grospelliergilles grospelliergilles added arccore Arccore component build Build configuration labels Nov 22, 2024
@grospelliergilles grospelliergilles self-assigned this Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.24%. Comparing base (21becaa) to head (b036145).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1786      +/-   ##
==========================================
- Coverage   70.26%   70.24%   -0.02%     
==========================================
  Files        2258     2258              
  Lines      162291   162283       -8     
  Branches    18696    18696              
==========================================
- Hits       114034   114003      -31     
- Misses      41488    41507      +19     
- Partials     6769     6773       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 3685e44 into main Nov 22, 2024
31 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-improve-arccore-configuration branch November 27, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arccore Arccore component build Build configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant