Skip to content

Return old value instead of void for atomic operations #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

grospelliergilles
Copy link
Member

Implement #1788.

@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup arcane:accelerator Arcane Accelerator API/Runtime labels Nov 25, 2024
@grospelliergilles grospelliergilles self-assigned this Nov 25, 2024
@grospelliergilles grospelliergilles force-pushed the dev/gg-return-old-value-for-atomics branch from e66ae05 to 6501665 Compare November 25, 2024 17:21
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.24%. Comparing base (17420b3) to head (6501665).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ane/src/arcane/tests/accelerator/AtomicUnitTest.cc 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1794      +/-   ##
==========================================
- Coverage   70.24%   70.24%   -0.01%     
==========================================
  Files        2259     2259              
  Lines      162374   162383       +9     
  Branches    18704    18705       +1     
==========================================
+ Hits       114057   114062       +5     
- Misses      41543    41548       +5     
+ Partials     6774     6773       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 5a907cf into main Nov 25, 2024
31 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-return-old-value-for-atomics branch November 30, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane:accelerator Arcane Accelerator API/Runtime arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant