Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in names of some IMemoryAllocator methods #1804

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

grospelliergilles
Copy link
Member

Change memoryRessource() to memoryResource() and guarantedAlignment() to guaranteedAlignment().

…)' et retourne 'eMemoryResource::Host' pour les implémentations standards
@grospelliergilles grospelliergilles added arccore Arccore component refactoring Code refactoring and cleanup labels Nov 30, 2024
@grospelliergilles grospelliergilles self-assigned this Nov 30, 2024
@grospelliergilles grospelliergilles force-pushed the dev/gg-fix-typo-in-memoryallocator-interface branch from 28f8c70 to 4e267e5 Compare November 30, 2024 10:25
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.26%. Comparing base (60c401f) to head (4e267e5).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...collections/arccore/collections/IMemoryAllocator.h 0.00% 5 Missing ⚠️
...collections/arccore/collections/MemoryAllocator.cc 0.00% 2 Missing ⚠️
arccore/src/collections/tests/TestArray.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1804      +/-   ##
==========================================
- Coverage   70.26%   70.26%   -0.01%     
==========================================
  Files        2261     2261              
  Lines      162440   162446       +6     
  Branches    18705    18705              
==========================================
+ Hits       114144   114146       +2     
- Misses      41523    41526       +3     
- Partials     6773     6774       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 2d69de6 into main Nov 30, 2024
30 of 31 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-fix-typo-in-memoryallocator-interface branch December 2, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arccore Arccore component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant