Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MemoryUtils #1806

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Refactor MemoryUtils #1806

merged 4 commits into from
Nov 30, 2024

Conversation

grospelliergilles
Copy link
Member

  • Move memory management methods from platform to MemoryUtils.
  • Make methods using IMemoryResourceMng internal to Arcane.
  • Rename MemoryRessourceMng to MemoryResourceMng.
  • Remove deprecated usage of some methods.

@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup arcane:accelerator Arcane Accelerator API/Runtime labels Nov 30, 2024
@grospelliergilles grospelliergilles self-assigned this Nov 30, 2024
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 70.90909% with 16 lines in your changes missing coverage. Please review.

Project coverage is 70.26%. Comparing base (3c827aa) to head (392f9de).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
arcane/src/arcane/utils/MemoryUtils.cc 56.52% 9 Missing and 1 partial ⚠️
arcane/src/arcane/utils/MemoryResourceMng.cc 87.50% 1 Missing and 1 partial ⚠️
arcane/src/arcane/utils/PlatformUtils.cc 71.42% 2 Missing ⚠️
...ne/src/arcane/accelerator/core/ReduceMemoryImpl.cc 0.00% 1 Missing ⚠️
arcane/src/arcane/impl/VariableSynchronizer.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1806      +/-   ##
==========================================
- Coverage   70.26%   70.26%   -0.01%     
==========================================
  Files        2261     2261              
  Lines      162446   162441       -5     
  Branches    18705    18705              
==========================================
- Hits       114143   114139       -4     
+ Misses      41533    41529       -4     
- Partials     6770     6773       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 9055f31 into main Nov 30, 2024
32 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-refactor-memory-utils branch December 2, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane:accelerator Arcane Accelerator API/Runtime arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant