Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to change memory resource used for default data allocator #1808

Merged

Conversation

grospelliergilles
Copy link
Member

The default is to use UnifiedMemory if an accelerator runtime is loaded and Host if it is not the case.
On accelerators where device memory is accessible from host and device (i.e. MI250X, MI300A or GH200), it may be better to use Device as the default memory resource.

@grospelliergilles grospelliergilles added enhancement New feature or request arcane Arcane Component arcane:accelerator Arcane Accelerator API/Runtime labels Dec 1, 2024
@grospelliergilles grospelliergilles self-assigned this Dec 1, 2024
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.26%. Comparing base (1bbc84c) to head (cd9d676).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
arcane/src/arcane/impl/ArcaneMain.cc 0.00% 6 Missing ⚠️
arcane/src/arcane/utils/MemoryUtils.cc 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1808   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files        2261     2261           
  Lines      162449   162477   +28     
  Branches    18706    18710    +4     
=======================================
+ Hits       114140   114165   +25     
- Misses      41535    41538    +3     
  Partials     6774     6774           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 5491086 into main Dec 1, 2024
32 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-add-support-to-change-data-memory-allocator branch December 2, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane:accelerator Arcane Accelerator API/Runtime arcane Arcane Component enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant