Use more explicit name for some NumArray methods #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e()' et 'fill()' en 'fillHost()'. Le nouveau nom est plus explicite du comportement attendu. Les anciennes méthodes existent toujours et seront rendues obsolète dans 6 mois.
…copy()' qui prennent une 'const RunQueue&' en argument.
grospelliergilles
added
arcane
grospelliergilles
force-pushed
the
dev/gg-use-more-explicit-name-for-some-numarray-methods
branch
from
ba2050f to
10cac1f
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
==========================================
- Coverage 70.26% 70.25% -0.01%
==========================================
Files 2261 2261
Lines 162477 162498 +21
Branches 18710 18710
==========================================
+ Hits 114165 114168 +3
- Misses 41538 41557 +19
+ Partials 6774 6773 -1 ☔ View full report in Codecov by Sentry. |
grospelliergilles
deleted the
dev/gg-use-more-explicit-name-for-some-numarray-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumArray::fill()toNumArray::fillHost()NumArray::resize()toNumArray::resizeDestructive()for rank greater than 1.const RunQueue&overload toNumArray::fill()andNumArray::copy().