Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated build system in alien/ArcaneInterface #1814

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

guignont
Copy link
Contributor

@guignont guignont commented Dec 2, 2024

A proposal to remove buildsystem part in Alien ArcaneInterface

Copy link
Member

@grospelliergilles grospelliergilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a good idea to remove duplication.
So now it uses the configuration from app_buildsystem_tools ?

@guignont
Copy link
Contributor Author

guignont commented Dec 3, 2024

I think it is a good idea to remove duplication. So now it uses the configuration from app_buildsystem_tools ?

Yes

@guignont
Copy link
Contributor Author

guignont commented Dec 6, 2024

@grospelliergilles It's seem that Ubuntu used for Codecov test lacks Mono and DotNet.
Is it possible to install them ?

@grospelliergilles
Copy link
Member

grospelliergilles commented Dec 6, 2024

@grospelliergilles It's seem that Ubuntu used for Codecov test lacks Mono and DotNet. Is it possible to install them ?

we no longer support mono but dotnet is present in the image used by codecov. You can see in this action for example; https://github.com/arcaneframework/framework/actions/runs/12191621972/job/34010826688. The tests used by dotnet contains the string corecrl in their name.

If needed we can install mono. @stdcm may know if it is really needed. Maybe it is possible to remove this find_package().

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.30%. Comparing base (8a25326) to head (34fa47e).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1814      +/-   ##
==========================================
- Coverage   70.31%   70.30%   -0.01%     
==========================================
  Files        2275     2275              
  Lines      163815   163813       -2     
  Branches    18871    18869       -2     
==========================================
- Hits       115183   115175       -8     
- Misses      41799    41801       +2     
- Partials     6833     6837       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… for dotnet binary

- also XBUILD_ARGS are deleted at the end so remove all settings related to XBUILDS_ARGS
Copy link
Member

@stdcm stdcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. The Arcane CI is ok but when installing and trying with ArcaneDemo, AlienLegacyPlugins is not found. Maybe the modifications to handle AlienPlugins are not fully reported in app_buildsystem_tools...?

@guignont
Copy link
Contributor Author

guignont commented Jan 2, 2025

@stdcm
Can you describe framework build and install procedure for use with ArcaneDemo because my ArcaneDemo build has no problem finding AlienLegacyPlugins ?

@guignont
Copy link
Contributor Author

I just made the following test in ArcaneDemo replacing build-system with the one in this branch.
The configuration with cmake works fine but when compiling there is errors in c++ generated files:

In file included from /work/guignont/work/ArcaneDemo/cmake-build-debug-arcane3user_gimkl2018b_localarcane/ArcaneDemo/axl/RootTester_axl.h:507:0,
from /work/guignont/work/ArcaneDemo/common/ArcGeoSim/src/ArcGeoSim/Tests/ServiceTesters/StrongOptionsTester/RootTesterService.h:10,
from /work/guignont/work/ArcaneDemo/common/ArcGeoSim/src/ArcGeoSim/Tests/ServiceTesters/StrongOptionsTester/RootTesterService.cc:6:
/work/guignont/work/ArcaneDemo/cmake-build-debug-arcane3user_gimkl2018b_localarcane/ArcaneDemo/axl/RootTester_CaseOptionsT.h:133:65: error: « ; » attendu à la fin de la déclaration du membre
Arcane::ConstArrayViewTypesStrongOptionsTester::eSimpleEnum simpleEnum4 const
^~~~~~~~~~~
/work/guignont/work/ArcaneDemo/cmake-build-debug-arcane3user_gimkl2018b_localarcane/ArcaneDemo/axl/RootTester_CaseOptionsT.h:134:3: error: expected unqualified-id before « { » token
{
^
/work/guignont/work/ArcaneDemo/cmake-build-debug-arcane3user_gimkl2018b_localarcane/ArcaneDemo/axl/RootTester_CaseOptionsT.h:137:65: error: « ; » attendu à la fin de la déclaration du membre
Arcane::ConstArrayViewTypesStrongOptionsTester::eSimpleEnum simpleEnum5 const
^~~~~~~~~~~
/work/guignont/work/ArcaneDemo/cmake-build-debug-arcane3user_gimkl2018b_localarcane/ArcaneDemo/axl/RootTester_CaseOptionsT.h:138:3: error: expected unqualified-id before « { » token
{

Anyway with a manual correction the build is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants