-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated build system in alien/ArcaneInterface #1814
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a good idea to remove duplication.
So now it uses the configuration from app_buildsystem_tools
?
Yes |
@grospelliergilles It's seem that Ubuntu used for Codecov test lacks Mono and DotNet. |
we no longer support If needed we can install |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1814 +/- ##
==========================================
- Coverage 70.31% 70.30% -0.01%
==========================================
Files 2275 2275
Lines 163815 163813 -2
Branches 18871 18869 -2
==========================================
- Hits 115183 115175 -8
- Misses 41799 41801 +2
- Partials 6833 6837 +4 ☔ View full report in Codecov by Sentry. |
… for dotnet binary - also XBUILD_ARGS are deleted at the end so remove all settings related to XBUILDS_ARGS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes. The Arcane CI is ok but when installing and trying with ArcaneDemo, AlienLegacyPlugins is not found. Maybe the modifications to handle AlienPlugins are not fully reported in app_buildsystem_tools...?
@stdcm |
I just made the following test in ArcaneDemo replacing build-system with the one in this branch. In file included from /work/guignont/work/ArcaneDemo/cmake-build-debug-arcane3user_gimkl2018b_localarcane/ArcaneDemo/axl/RootTester_axl.h:507:0, Anyway with a manual correction the build is ok. |
A proposal to remove buildsystem part in Alien ArcaneInterface