Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move types of component 'arccore/serialize' from namespace Arccore to namespace Arcane #1978

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions arcane/src/arcane/core/ArcaneTypes.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,11 @@
// 'arcane/utils' utilisent des fichiers d'en-tête de 'arcane/core'. C'est
// le cas par exemple des fichiers '*AMR*.h'.

namespace Arccore
namespace Arcane
{
class ISerializer;
}
namespace Arcane
{
using Arccore::ISerializer;

}
/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,17 @@
/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/

namespace Arccore
namespace Arcane
{
class ISerializer;
}
namespace Arccore
{
class ITimeMetricCollector;
using Arcane::ISerializer;
}
namespace Arcane
{
using Arccore::ISerializer;
using Arccore::ITimeMetricCollector;
}

Expand Down
26 changes: 13 additions & 13 deletions arccore/src/serialize/arccore/serialize/BasicSerializer.cc
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
// -*- tab-width: 2; indent-tabs-mode: nil; coding: utf-8-with-signature -*-
//-----------------------------------------------------------------------------
// Copyright 2000-2024 CEA (www.cea.fr) IFPEN (www.ifpenergiesnouvelles.com)
// Copyright 2000-2025 CEA (www.cea.fr) IFPEN (www.ifpenergiesnouvelles.com)
// See the top-level COPYRIGHT file for details.
// SPDX-License-Identifier: Apache-2.0
//-----------------------------------------------------------------------------
/*---------------------------------------------------------------------------*/
/* BasicSerializer.cc (C) 2000-2024 */
/* BasicSerializer.cc (C) 2000-2025 */
/* */
/* Implémentation simple de 'ISerializer'. */
/*---------------------------------------------------------------------------*/
Expand All @@ -23,7 +23,7 @@
/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/

namespace Arccore
namespace Arcane
{

/*---------------------------------------------------------------------------*/
Expand Down Expand Up @@ -122,7 +122,7 @@
Span<Float128> m_float128_view; //!< Vue les Float128
Span<Int128> m_int128_view; //!< Vue les Int128

Int64ArrayView m_sizes_view; //!< Vue pour les tailles (doit être un multiple de ALIGN_SIZE);
ArrayView<Int64> m_sizes_view; //!< Vue pour les tailles (doit être un multiple de ALIGN_SIZE);

/*!
* \brief Copie des tailles utilisée pour l'envoie en plusieurs fois.
Expand Down Expand Up @@ -225,7 +225,7 @@
_fillPadding(float128_position, padded_float128_size);
_fillPadding(int128_position, padded_int128_size);

m_sizes_view = Int64ArrayView(NB_SIZE_ELEM, (Int64*)&m_buffer_view[0]);
m_sizes_view = ArrayView<Int64>(NB_SIZE_ELEM, (Int64*)&m_buffer_view[0]);
m_sizes_view.fill(0);

m_sizes_view[IDX_TAG] = SERIALIZE_TAG;
Expand Down Expand Up @@ -299,15 +299,15 @@
return m_buffer_view;
}

Int64ConstArrayView sizesBuffer() const override
ConstArrayView<Int64> sizesBuffer() const override

Check warning on line 302 in arccore/src/serialize/arccore/serialize/BasicSerializer.cc

View check run for this annotation

Codecov / codecov/patch

arccore/src/serialize/arccore/serialize/BasicSerializer.cc#L302

Added line #L302 was not covered by tests
{
return m_sizes_view;
}

void preallocate(Int64 size) override
{
_allocBuffer(size);
m_sizes_view = Int64ArrayView(NB_SIZE_ELEM, (Int64*)&m_buffer_view[0]);
m_sizes_view = ArrayView<Int64>(NB_SIZE_ELEM, (Int64*)&m_buffer_view[0]);
}

void releaseBuffer() override
Expand Down Expand Up @@ -365,13 +365,13 @@
_checkAlignment();
}

ByteConstArrayView copyAndGetSizesBuffer() override
ConstArrayView<Byte> copyAndGetSizesBuffer() override
{
// Recopie dans \a m_size_copy_buffer les valeurs de \a m_size_view
// et retourne un pointeur sur \a m_size_copy_buffer.
Int64ArrayView copy_buf(NB_SIZE_ELEM, m_size_copy_buffer);
ArrayView<Int64> copy_buf(NB_SIZE_ELEM, m_size_copy_buffer);
copy_buf.copy(m_sizes_view);
ByteConstArrayView bytes(sizeof(m_size_copy_buffer), (const Byte*)m_size_copy_buffer);
ConstArrayView<Byte> bytes(sizeof(m_size_copy_buffer), (const Byte*)m_size_copy_buffer);
return bytes;
}

Expand All @@ -382,7 +382,7 @@

void printSizes(std::ostream& o) const override
{
Int64ConstArrayView sbuf_sizes = this->sizesBuffer();
ConstArrayView<Int64> sbuf_sizes = this->sizesBuffer();

Check warning on line 385 in arccore/src/serialize/arccore/serialize/BasicSerializer.cc

View check run for this annotation

Codecov / codecov/patch

arccore/src/serialize/arccore/serialize/BasicSerializer.cc#L385

Added line #L385 was not covered by tests
Int64 total_size = totalSize();
Span<Byte> bytes = m_buffer_view;
o << " bytes " << bytes.size()
Expand Down Expand Up @@ -1525,7 +1525,7 @@
/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/

ByteConstArrayView BasicSerializer::
ConstArrayView<Byte> BasicSerializer::
copyAndGetSizesBuffer()
{
return _p()->copyAndGetSizesBuffer();
Expand All @@ -1534,7 +1534,7 @@
/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/

Int64ConstArrayView BasicSerializer::
ConstArrayView<Int64> BasicSerializer::

Check warning on line 1537 in arccore/src/serialize/arccore/serialize/BasicSerializer.cc

View check run for this annotation

Codecov / codecov/patch

arccore/src/serialize/arccore/serialize/BasicSerializer.cc#L1537

Added line #L1537 was not covered by tests
sizesBuffer()
{
return _p()->sizesBuffer();
Expand Down
32 changes: 14 additions & 18 deletions arccore/src/serialize/arccore/serialize/BasicSerializer.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@
namespace Arcane
{
class BasicSerializeGatherMessage;
}

namespace Arccore
{

/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/
Expand Down Expand Up @@ -215,31 +211,31 @@ class ARCCORE_SERIALIZE_EXPORT BasicSerializer

void putReal(Real value) override
{
put(RealConstArrayView(1, &value));
put(ConstArrayView<Real>(1, &value));
}
void putInt64(Int64 value) override
{
put(Int64ConstArrayView(1, &value));
put(ConstArrayView<Int64>(1, &value));
}
void putInt32(Int32 value) override
{
put(Int32ConstArrayView(1, &value));
put(ConstArrayView<Int32>(1, &value));
}
void putInt16(Int16 value) override
{
put(Int16ConstArrayView(1, &value));
put(ConstArrayView<Int16>(1, &value));
}
void putInteger(Integer value) override
{
#ifdef ARCANE_64BIT
put(Int64ConstArrayView(1, &value));
put(ConstArrayView<Int64>(1, &value));
#else
put(Int32ConstArrayView(1, &value));
put(ConstArrayView<Int32>(1, &value));
#endif
}
void putByte(Byte value) override
{
put(ByteConstArrayView(1, &value));
put(ConstArrayView<Byte>(1, &value));
}
void putInt8(Int8 value) override
{
Expand Down Expand Up @@ -278,11 +274,11 @@ class ARCCORE_SERIALIZE_EXPORT BasicSerializer
void putArray(Span<const Float128> values) override;
void putArray(Span<const Int128> values) override;

void get(RealArrayView values) override { ThatClass::getSpan(values); }
void get(Int64ArrayView values) override { ThatClass::getSpan(values); }
void get(Int32ArrayView values) override { ThatClass::getSpan(values); }
void get(Int16ArrayView values) override { ThatClass::getSpan(values); }
void get(ByteArrayView values) override { ThatClass::getSpan(values); }
void get(ArrayView<Real> values) override { ThatClass::getSpan(values); }
void get(ArrayView<Int64> values) override { ThatClass::getSpan(values); }
void get(ArrayView<Int32> values) override { ThatClass::getSpan(values); }
void get(ArrayView<Int16> values) override { ThatClass::getSpan(values); }
void get(ArrayView<Byte> values) override { ThatClass::getSpan(values); }

void getSpan(Span<Real> values) override;
void getSpan(Span<Int16> values) override;
Expand Down Expand Up @@ -429,11 +425,11 @@ class ARCCORE_SERIALIZE_EXPORT BasicSerializer

public:

ByteConstArrayView copyAndGetSizesBuffer();
ConstArrayView<Byte> copyAndGetSizesBuffer();
Span<Byte> globalBuffer();
Span<const Byte> globalBuffer() const;
ARCCORE_DEPRECATED_2020("Do not use. get total size with totalSize()")
Int64ConstArrayView sizesBuffer();
ConstArrayView<Int64> sizesBuffer();
Int64 totalSize() const;
void preallocate(Int64 size);
void releaseBuffer();
Expand Down
22 changes: 15 additions & 7 deletions arccore/src/serialize/arccore/serialize/ISerializer.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/

namespace Arccore
namespace Arcane
{

/*---------------------------------------------------------------------------*/
Expand Down Expand Up @@ -344,19 +344,19 @@ class ARCCORE_SERIALIZE_EXPORT ISerializer

//! Récupère le tableau \a values
ARCCORE_DEPRECATED_2020("Use getSpan() instead")
virtual void get(RealArrayView values) = 0;
virtual void get(ArrayView<Real> values) = 0;
//! Récupère le tableau \a values
ARCCORE_DEPRECATED_2020("Use getSpan() instead")
virtual void get(Int16ArrayView values) = 0;
virtual void get(ArrayView<Int16> values) = 0;
//! Récupère le tableau \a values
ARCCORE_DEPRECATED_2020("Use getSpan() instead")
virtual void get(Int32ArrayView values) = 0;
virtual void get(ArrayView<Int32> values) = 0;
//! Récupère le tableau \a values
ARCCORE_DEPRECATED_2020("Use getSpan() instead")
virtual void get(Int64ArrayView values) = 0;
virtual void get(ArrayView<Int64> values) = 0;
//! Récupère le tableau \a values
ARCCORE_DEPRECATED_2020("Use getSpan() instead")
virtual void get(ByteArrayView values) = 0;
virtual void get(ArrayView<Byte> values) = 0;

public:

Expand Down Expand Up @@ -465,7 +465,15 @@ createSerializer();
/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/

} // End namespace Arccore
} // End namespace Arcane

/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/

namespace Arccore
{
using Arcane::createSerializer;
}

/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/
Expand Down
9 changes: 6 additions & 3 deletions arccore/src/serialize/arccore/serialize/SerializeGlobal.cc
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
// -*- tab-width: 2; indent-tabs-mode: nil; coding: utf-8-with-signature -*-
//-----------------------------------------------------------------------------
// Copyright 2000-2024 CEA (www.cea.fr) IFPEN (www.ifpenergiesnouvelles.com)
// Copyright 2000-2025 CEA (www.cea.fr) IFPEN (www.ifpenergiesnouvelles.com)
// See the top-level COPYRIGHT file for details.
// SPDX-License-Identifier: Apache-2.0
//-----------------------------------------------------------------------------
/*---------------------------------------------------------------------------*/
/* SerializeGlobal.cc (C) 2000-2024 */
/* SerializeGlobal.cc (C) 2000-2025 */
/* */
/* Définitions globales de la composante 'Serialize' de 'Arccore'. */
/*---------------------------------------------------------------------------*/
Expand All @@ -17,7 +17,10 @@
#include "arccore/base/Span.h"
#include "arccore/base/BasicDataType.h"

namespace Arccore
/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/

namespace Arcane
{

/*---------------------------------------------------------------------------*/
Expand Down
8 changes: 4 additions & 4 deletions arccore/src/serialize/arccore/serialize/SerializeGlobal.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/

namespace Arccore
namespace Arcane
{

/*---------------------------------------------------------------------------*/
Expand All @@ -47,10 +47,10 @@ class BasicSerializer;
/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/

namespace Arcane
namespace Arccore
{
using Arccore::ISerializer;
using Arccore::BasicSerializer;
using Arcane::ISerializer;
using Arcane::BasicSerializer;
}

/*---------------------------------------------------------------------------*/
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
// -*- tab-width: 2; indent-tabs-mode: nil; coding: utf-8-with-signature -*-
//-----------------------------------------------------------------------------
// Copyright 2000-2024 CEA (www.cea.fr) IFPEN (www.ifpenergiesnouvelles.com)
// Copyright 2000-2025 CEA (www.cea.fr) IFPEN (www.ifpenergiesnouvelles.com)
// See the top-level COPYRIGHT file for details.
// SPDX-License-Identifier: Apache-2.0
//-----------------------------------------------------------------------------
/*---------------------------------------------------------------------------*/
/* BasicSerializerInternal.h (C) 2000-2024 */
/* BasicSerializerInternal.h (C) 2000-2025 */
/* */
/* Partie interne de 'BasicSerializer'. */
/*---------------------------------------------------------------------------*/
Expand All @@ -20,7 +20,7 @@
/*---------------------------------------------------------------------------*/
/*---------------------------------------------------------------------------*/

namespace Arccore
namespace Arcane
{

/*---------------------------------------------------------------------------*/
Expand Down Expand Up @@ -52,8 +52,8 @@ class ARCCORE_SERIALIZE_EXPORT BasicSerializer::Impl
virtual void copy(Impl* rhs) = 0;
virtual Span<Byte> globalBuffer() = 0;
virtual Span<const Byte> globalBuffer() const = 0;
virtual Int64ConstArrayView sizesBuffer() const = 0;
virtual ByteConstArrayView copyAndGetSizesBuffer() = 0;
virtual ConstArrayView<Int64> sizesBuffer() const = 0;
virtual ConstArrayView<Byte> copyAndGetSizesBuffer() = 0;
virtual void preallocate(Int64 size) = 0;
virtual void releaseBuffer() = 0;
virtual void setFromSizes() = 0;
Expand Down
Loading