Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uniqueId() of first node to sort items in ItemsOwnerBuilder #1991

Merged

Conversation

grospelliergilles
Copy link
Member

No description provided.

…r noeud de l'entité pour trier la liste des entités.

Cela permet d'essayer de diminuer le nombre d'entités envoyées lors de
l'échange final.
@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup labels Feb 17, 2025
@grospelliergilles grospelliergilles self-assigned this Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (2643160) to head (9a579d4).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
arcane/src/arcane/mesh/ItemsOwnerBuilder.cc 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1991      +/-   ##
==========================================
- Coverage   70.52%   70.52%   -0.01%     
==========================================
  Files        2286     2286              
  Lines      166929   166934       +5     
  Branches    19184    19186       +2     
==========================================
  Hits       117725   117725              
- Misses      42194    42197       +3     
- Partials     7010     7012       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit cc00e61 into main Feb 17, 2025
33 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-use-first-node-to-sort-in-itemownerbuilder branch February 24, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant