Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move several classes of 'arccore/message_passing_mpi' in internal Arccore API #1992

Conversation

grospelliergilles
Copy link
Member

These classes are only used by Arccore and Arcane and should not be public.

@grospelliergilles grospelliergilles added arcane Arcane Component arccore Arccore component refactoring Code refactoring and cleanup labels Feb 18, 2025
@grospelliergilles grospelliergilles self-assigned this Feb 18, 2025
@grospelliergilles grospelliergilles force-pushed the dev/gg-move-some-message-passing-mpi-classes-in-internal branch from 9b4924c to 424682d Compare February 18, 2025 18:11
@grospelliergilles grospelliergilles force-pushed the dev/gg-move-some-message-passing-mpi-classes-in-internal branch from 424682d to c9a846c Compare February 18, 2025 18:13
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 77.27273% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (7f80370) to head (c9a846c).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...el/mpi/MpiParallelNonBlockingCollectiveDispatch.cc 50.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1992      +/-   ##
==========================================
+ Coverage   70.55%   70.58%   +0.02%     
==========================================
  Files        2291     2291              
  Lines      167619   167619              
  Branches    19314    19314              
==========================================
+ Hits       118265   118306      +41     
+ Misses      42264    42223      -41     
  Partials     7090     7090              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit bc9f4c5 into main Feb 18, 2025
33 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-move-some-message-passing-mpi-classes-in-internal branch February 24, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component arccore Arccore component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant