Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not deactivate ghost layer update when item family network is present. #1998

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

stdcm
Copy link
Member

@stdcm stdcm commented Feb 21, 2025

  • ItemFamilyNetwork is present when graph activated
  • Only use of item families dependencies in synchronization doesn't need ghost update

…etwork is present.

ItemFamilyNetwork is used with the graph.
@stdcm stdcm self-assigned this Feb 21, 2025
@stdcm stdcm added bug Something isn't working arcane Arcane Component labels Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.56%. Comparing base (ebe8a25) to head (4b282b7).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
arcane/src/arcane/mesh/DynamicMesh.cc 0.00% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1998   +/-   ##
=======================================
  Coverage   70.56%   70.56%           
=======================================
  Files        2291     2291           
  Lines      167594   167594           
  Branches    19314    19314           
=======================================
+ Hits       118260   118263    +3     
+ Misses      42242    42240    -2     
+ Partials     7092     7091    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdcm stdcm merged commit 7bd8241 into main Feb 21, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant