Use std::less for comparison in GenericSorter.
#2002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grospelliergilles
added
bug
…nericSorter'. L'utilisation d'une lambda avec 'ARCCORE_HOST_DEVICE' fait planter la compilation avec certaines combinaisons de GCC/NVCC.
grospelliergilles
force-pushed
the
dev/gg-use-stdless-for-comparison-in-genericsorter
branch
from
2f6bb87 to
6e51694
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2002 +/- ##
==========================================
- Coverage 70.57% 70.57% -0.01%
==========================================
Files 2288 2288
Lines 167405 167404 -1
Branches 19281 19281
==========================================
- Hits 118153 118149 -4
Misses 42178 42178
- Partials 7074 7077 +3 ☔ View full report in Codecov by Sentry. |
grospelliergilles
deleted the
dev/gg-use-stdless-for-comparison-in-genericsorter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a lambda decorated with
ARCCORE_HOST_DEVICEfor comparison produces runtime error with some combination of GCC/NVCC and OS (the exact combination is unknown).