Improve the Basic Mesh Subdivider #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
+ Coverage 70.57% 70.59% +0.02%
==========================================
Files 2288 2288
Lines 167410 167413 +3
Branches 19285 19286 +1
==========================================
+ Hits 118149 118187 +38
+ Misses 42181 42146 -35
Partials 7080 7080 ☔ View full report in Codecov by Sentry. |
grospelliergilles
approved these changes
Feb 25, 2025
Comment on lines
1959
to
1960
| info() << "Les motifs de rafinement ont changés pour les mailles ayant les types suivant:Quad4,Triangle3,Hexaedron8,Tetraedron4." ; | ||
| info() << "Les type d'élément en sortie seront:\nQuad4->Triangle3\nTriangle3->Quad4\nHexaedron8->Tetraedron4\nTetraedron4->Hexaedron8" ; |
There was a problem hiding this comment.
Listing message should be in english.
…f 1 and the input are quads, the output will be triangles.
…bdivider encountered some collision.
… modification of the hash generation function.
…tern storage yet.
ValentinPOSTAT
force-pushed
the
dev/vp-basic-mesh-subdivider-service
branch
from
59fa681 to
fb115a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more tests and modified the hash function to reduce collisions in the largest cases (currently tested ~ 2 million).
Modified the function generateHashUniqueId.