Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to query work on RunQueueEvent #2006

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

grospelliergilles
Copy link
Member

Add method RunQueueEvent::hasPendingWork() to know if the RunQueue recorded in a RunQueueEvent has work.
This is implemented using cudaQueryEvent() and hipQueryEvent(). It is not yet implemented with SYCL.

… pour savoir si les RunQueue associées à un évènement ont du travail.

Cette méthode encapsule 'cudaQueryEvent()' ou 'hipQueryEvent()'.
@grospelliergilles grospelliergilles added enhancement New feature or request arcane Arcane Component arcane:accelerator Arcane Accelerator API/Runtime labels Feb 25, 2025
@grospelliergilles grospelliergilles self-assigned this Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.57%. Comparing base (e001132) to head (e43e36a).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...e/src/arcane/tests/accelerator/RunQueueUnitTest.cc 90.00% 0 Missing and 2 partials ⚠️
...rcane/src/arcane/accelerator/core/RunQueueEvent.cc 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
- Coverage   70.60%   70.57%   -0.03%     
==========================================
  Files        2288     2288              
  Lines      167405   167410       +5     
  Branches    19281    19285       +4     
==========================================
- Hits       118196   118150      -46     
- Misses      42136    42183      +47     
- Partials     7073     7077       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 20e0688 into main Feb 25, 2025
32 of 33 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-add-accelerator-query-event branch March 4, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane:accelerator Arcane Accelerator API/Runtime arcane Arcane Component enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant