Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle arbitrary face order in polyhedral vtk face mesh #2009

Merged

Conversation

stdcm
Copy link
Member

@stdcm stdcm commented Feb 27, 2025

No description provided.

Before it was needed to describe the faces in the same order in the main mesh and the face mesh files. This no longer stands.
…rom vtu to vtp.

The face mesh is a Polydata structure thus its extension in vtk xml must be vtp.
@stdcm stdcm self-assigned this Feb 27, 2025
@stdcm stdcm added enhancement New feature or request arcane Arcane Component labels Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.60%. Comparing base (f7fa62b) to head (b7480cb).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
- Coverage   70.60%   70.60%   -0.01%     
==========================================
  Files        2288     2288              
  Lines      167470   167469       -1     
  Branches    19291    19291              
==========================================
- Hits       118240   118236       -4     
- Misses      42147    42149       +2     
- Partials     7083     7084       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdcm stdcm merged commit 3996037 into main Feb 27, 2025
33 checks passed
@stdcm stdcm deleted the dev/sdc-handle-arbitrary-face-order-in-polyhedral-vtk-face-mesh branch February 27, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant