Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup classes handling Events #2010

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Conversation

grospelliergilles
Copy link
Member

  • Use googlest to test theses classes
  • Prevent copy or assignment for EventObservableBase
  • Make some functions inline.

@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup labels Feb 27, 2025
@grospelliergilles grospelliergilles self-assigned this Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 95.08197% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.60%. Comparing base (b7480cb) to head (98f1c03).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
arcane/src/arcane/utils/Event.cc 81.81% 0 Missing and 2 partials ⚠️
arcane/src/arcane/utils/tests/TestEvent.cc 97.61% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2010   +/-   ##
=======================================
  Coverage   70.60%   70.60%           
=======================================
  Files        2288     2289    +1     
  Lines      167469   167466    -3     
  Branches    19291    19290    -1     
=======================================
+ Hits       118236   118241    +5     
+ Misses      42149    42145    -4     
+ Partials     7084     7080    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit b54661d into main Feb 27, 2025
33 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-cleanup-event branch March 4, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant