Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for notification when adding/removing items. #2013

Merged
merged 6 commits into from
Mar 1, 2025

Conversation

grospelliergilles
Copy link
Member

Add an event in DynamicMeshKindInfos to be notified when items are added or removed.
This event is accessible via IItemFamily::itemListChangedEvent()

…ntObservable&'.

Cela permet d'éviter de retourner des références (au sens C++) dans les
méthodes virtuelles.
… gérer les arguments de l'évènement d'ajout/suppression d'entités.
…notifié lors de l'ajout ou supression d'une entité.
…ur être notifié de l'ajout/suppression d'entité dans la famille.
@grospelliergilles grospelliergilles added enhancement New feature or request arcane Arcane Component labels Mar 1, 2025
@grospelliergilles grospelliergilles self-assigned this Mar 1, 2025
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 67.58621% with 47 lines in your changes missing coverage. Please review.

Project coverage is 70.64%. Comparing base (3f556f0) to head (dd41e3a).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
arcane/src/arcane/tests/MeshModificationTester.cc 64.95% 38 Missing and 3 partials ⚠️
arcane/src/arcane/mesh/DynamicMeshKindInfos.cc 60.00% 4 Missing ⚠️
arcane/src/arcane/mesh/DynamicMeshKindInfos.h 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2013      +/-   ##
==========================================
+ Coverage   70.60%   70.64%   +0.03%     
==========================================
  Files        2289     2290       +1     
  Lines      167466   167525      +59     
  Branches    19290    19298       +8     
==========================================
+ Hits       118239   118345     +106     
+ Misses      42147    42091      -56     
- Partials     7080     7089       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit d592007 into main Mar 1, 2025
33 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-add-event-for-add-remove-item branch March 12, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant