Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad comparison for boundary faces in ItemsOwnerBuilder #2016

Merged

Conversation

grospelliergilles
Copy link
Member

No description provided.

@grospelliergilles grospelliergilles added bug Something isn't working arcane Arcane Component labels Mar 2, 2025
@grospelliergilles grospelliergilles self-assigned this Mar 2, 2025
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.70%. Comparing base (b5f8c4b) to head (5b19f87).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2016   +/-   ##
=======================================
  Coverage   70.70%   70.70%           
=======================================
  Files        2290     2290           
  Lines      167531   167531           
  Branches    19298    19298           
=======================================
+ Hits       118445   118448    +3     
+ Misses      42002    42000    -2     
+ Partials     7084     7083    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 8427979 into main Mar 2, 2025
33 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-fix-bad-comparison-in-itemsownerbuilder branch March 12, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant