Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method ItemGenericInfoListView::isShared() #2018

Merged

Conversation

grospelliergilles
Copy link
Member

This method is available on accelerator.

@grospelliergilles grospelliergilles added enhancement New feature or request arcane Arcane Component arcane:accelerator Arcane Accelerator API/Runtime labels Mar 3, 2025
@grospelliergilles grospelliergilles self-assigned this Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.70%. Comparing base (d016981) to head (84d788f).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...e/tests/accelerator/AcceleratorItemInfoUnitTest.cc 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2018      +/-   ##
==========================================
- Coverage   70.70%   70.70%   -0.01%     
==========================================
  Files        2290     2290              
  Lines      167532   167544      +12     
  Branches    19298    19300       +2     
==========================================
+ Hits       118450   118455       +5     
- Misses      42000    42003       +3     
- Partials     7082     7086       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 889a481 into main Mar 3, 2025
33 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-add-isshared-in-itemgenericinfolistview branch March 12, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane:accelerator Arcane Accelerator API/Runtime arcane Arcane Component enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ItemGenericInfoListView::isShared(ItemLocalId local_id) not available on accelerator
1 participant