Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pull_request_template.md #69

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Create pull_request_template.md #69

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
515f052
Create pull_request_template.md
mryave Jul 19, 2024
cf12842
Update pull_request_template.md
mryave Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
## Ticket
<!---
Attach a link to the ticket. leave nothing other than this hyperlinked task here.
-->
[Task](https://arceeai.slack.com/lists/XXXXXXX/YYYYYYY?record_id=ZZZZZZZZ)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like we're use slack for platform and potentially jira for research. i chose slack prematurely, but open to swapping this out

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mryave since this one is public facing/OS we might want to do PR open for community

Julien was forking and PR'ing in like we might want users doing here (eventually)


## Description
<!---
include a summary of the change in technical terms. The groomed product ticket provides the what, why, and helpful direction as to how if necessary.
if there is no groomed ticket, then that all goes here when necessary.
-->
## Screenshots/Instructions
<!---
how should a reviewer test the feature locally or in staging when possible. Provide screenshots/gifs if applicable.
-->
## Checklist
Before you submit this PR, please make sure you have completed the following items:
- [ ] Tested against a dev environment?
- [ ] Documentation is up to date or expanded?
- [ ] Groomed task link is attached?
- [ ] Additional checklists attached based on playbooks relevant to task?
- [ ] Did you get a code review?

<!---
Playbooks are not error/bug/outage specific like runbooks (which we want to have too). These are repeatable engineering tasks such as the process of running a db migration.
Both can become easy targets for further automation and can provide a good catcher's mit for hidden processes or toil
-->

## Additional Notes
<!---
Include any additional information, highlight TODOs, open questions, etc.
-->
Loading