Add scheme rights form/report, #151 #180
Conversation
|
@njkim when able, could you rebase this? Looks like there's a lot of leakage from Johnathan's work. |
njkim
force-pushed
the
151_scheme_rights_form
branch
from
b889521 to
79a9a92
Compare
arches_lingo/src/arches_lingo/components/scheme/report/SchemeLicense.vue
Show resolved
Hide resolved
| todo | ||
| </SchemeReportSection> | ||
| <div> | ||
| <div v-if="!mode || mode === VIEW"> |
There was a problem hiding this comment.
Is there a reason this section is divided by mode? Shouldn't it just be an arg fed into sub components, or am I missing something?
There was a problem hiding this comment.
I may be missing something here... could it not be 1 set of components? eg
<div>
<h4>{{ $gettext("Rights Holders") }}</h4>
<ResourceInstanceRelationships
:value="schemeRights?.right_holder"
:options="actorRdmOptions"
:mode="mode"
@update="
(val) =>
onUpdateResourceInstance(
'right_holder',
val,
actorRdmOptions ?? [],
)
"
/>
<h4>{{ $gettext("Rights Type") }}</h4>
<ReferenceDatatype
:value="schemeRights?.right_type"
:options="rightTypeOptions"
:multi-value="false"
:mode="mode"
@update="
(val) =>
onUpdateSchemeRightReferenceDatatype(
'right_type',
val,
)
"
/>
</div>
<div>
<h4>{{ $gettext("Statement") }}</h4>
<NonLocalizedString
:value="schemeRightStatement?.right_statement_content"
:mode="mode"
@update="
(val) => onUpdateString('right_statement_content', val)
"
/>
<h4>{{ $gettext("Statement Language") }}</h4>
<ReferenceDatatype
:value="schemeRightStatement?.right_statement_language"
:mode="mode"
:multi-value="false"
:options="languageOptions"
@update="
(val) =>
onUpdateSchemeRightStatementReferenceDatatype(
'right_statement_language',
val,
)
"
/>
<h4>{{ $gettext("Statement Type") }}</h4>
<ReferenceDatatype
:value="schemeRightStatement?.right_statement_type"
:mode="mode"
:multi-value="false"
:options="noteOptions"
@update="
(val) =>
onUpdateSchemeRightStatementReferenceDatatype(
'right_statement_type',
val,
)
"
/>
<h4>{{ $gettext("Statement Type Metatype") }}</h4>
<ReferenceDatatype
:value="schemeRightStatement?.right_statement_type_metatype"
:mode="mode"
:multi-value="false"
:options="metatypesOptions"
@update="
(val) =>
onUpdateSchemeRightStatementReferenceDatatype(
'right_statement_type_metatype',
val,
)
"
/>
<Button
v-if="mode === EDIT"
:label="$gettext('Update')"
@click="saveRights"
></Button>
There was a problem hiding this comment.
@chrabyrd Ah, I see what you mean. That makes sense. Thought they looked different enough but I can see that they can be combined.
|
@njkim this appears to be failing builds. It looks like something the pre-commit hooks would catch, but if not mind running |
| todo | ||
| </SchemeReportSection> | ||
| <div> | ||
| <div v-if="!mode || mode === VIEW"> |
There was a problem hiding this comment.
I may be missing something here... could it not be 1 set of components? eg
<div>
<h4>{{ $gettext("Rights Holders") }}</h4>
<ResourceInstanceRelationships
:value="schemeRights?.right_holder"
:options="actorRdmOptions"
:mode="mode"
@update="
(val) =>
onUpdateResourceInstance(
'right_holder',
val,
actorRdmOptions ?? [],
)
"
/>
<h4>{{ $gettext("Rights Type") }}</h4>
<ReferenceDatatype
:value="schemeRights?.right_type"
:options="rightTypeOptions"
:multi-value="false"
:mode="mode"
@update="
(val) =>
onUpdateSchemeRightReferenceDatatype(
'right_type',
val,
)
"
/>
</div>
<div>
<h4>{{ $gettext("Statement") }}</h4>
<NonLocalizedString
:value="schemeRightStatement?.right_statement_content"
:mode="mode"
@update="
(val) => onUpdateString('right_statement_content', val)
"
/>
<h4>{{ $gettext("Statement Language") }}</h4>
<ReferenceDatatype
:value="schemeRightStatement?.right_statement_language"
:mode="mode"
:multi-value="false"
:options="languageOptions"
@update="
(val) =>
onUpdateSchemeRightStatementReferenceDatatype(
'right_statement_language',
val,
)
"
/>
<h4>{{ $gettext("Statement Type") }}</h4>
<ReferenceDatatype
:value="schemeRightStatement?.right_statement_type"
:mode="mode"
:multi-value="false"
:options="noteOptions"
@update="
(val) =>
onUpdateSchemeRightStatementReferenceDatatype(
'right_statement_type',
val,
)
"
/>
<h4>{{ $gettext("Statement Type Metatype") }}</h4>
<ReferenceDatatype
:value="schemeRightStatement?.right_statement_type_metatype"
:mode="mode"
:multi-value="false"
:options="metatypesOptions"
@update="
(val) =>
onUpdateSchemeRightStatementReferenceDatatype(
'right_statement_type_metatype',
val,
)
"
/>
<Button
v-if="mode === EDIT"
:label="$gettext('Update')"
@click="saveRights"
></Button>
| ontologyProperty: "ac41d9be-79db-4256-b368-2f4559cfbe55", | ||
| inverseOntologyProperty: "ac41d9be-79db-4256-b368-2f4559cfbe55", |
There was a problem hiding this comment.
is there a way to not hardcode UUIDs on the frontend? If not addressed here, could you file a followup ticket for this?
There was a problem hiding this comment.
@chrabyrd The uuids are removed because the ontology on the current models are actually not assigned (though I believe they should be).
I agree that they should not be hard-coded here, especially since the graph can change.
I think we need more discussion where/how it should get. I feel the related resource object should not be built at all in the front-end but I am not sure.
Here is a new ticket. #191
| const metatypesOptions = ref<ControlledListItem[]>(); | ||
| const parentExists = ref(false); | ||
|
|
||
| withDefaults( |
There was a problem hiding this comment.
nit: props go just under imports
Add the scheme rights and the right statement cards to the scheme report/editor.
Two cardinality-1 cards are treated as one card.