Update graphs for correct tile keys, cope with reference datatype changes #208
+4,393
−4,386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrabyrd
reviewed
Feb 6, 2025
arches_lingo/serializers.py
Outdated
| @@ -63,30 +64,37 @@ def validate_appellative_status(self, data): | |||
| raise ValidationError(msg) | |||
|
|
|||
| if data: | |||
There was a problem hiding this comment.
not blocking on this, but this function looks like it could be broken out into other functions?
jacobtylerwalls
force-pushed
the
jtw/validate-label-explicitness
branch
from
bcb14c9 to
56f475d
Compare
johnatawnclementawn
requested changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the partner PR to archesproject/arches-references#59.
listid->list_idin models (default value for references dt nodes).urinot["uri"]assuming Create dataclass for reference datatype and improve validation #45 arches-references#59 merges)validate_appellative_status()method for explicitness, fewer nested fallbacks likenext(iter(...Should wait to merge this until archesproject/arches-references#59.