Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sort of nodes during election's refinement #1354

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

samuelmanzanera
Copy link
Member

Description

This PR aims to resolve the problem of concentration in the validation node election due to an invalid statement in the election algorithm refinement (when there is not enough nodes to validate the constraints)

Fixes #1353

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added bug Something isn't working mining Involve transaction validation and mining election labels Dec 20, 2023
@bchamagne bchamagne added this to the 1.4.3 milestone Dec 20, 2023
@Neylix Neylix merged commit f925ff1 into develop Dec 21, 2023
1 check passed
@Neylix Neylix deleted the fix_election_sort branch December 21, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working election mining Involve transaction validation and mining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Election of (cross)validators looks wrong
3 participants