Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListenerProtocol catch errors #1370

Merged
merged 3 commits into from
Jan 10, 2024
Merged

ListenerProtocol catch errors #1370

merged 3 commits into from
Jan 10, 2024

Conversation

bchamagne
Copy link
Contributor

Description

  • Handle messages that are atoms
  • Handle messages that does not decode

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Write unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added bug Something isn't working P2P Involve P2P networking labels Jan 8, 2024
@bchamagne bchamagne changed the title Lsterner protocol catch err ListenerProtocol catch errors Jan 8, 2024
@bchamagne bchamagne force-pushed the listener-protocol-rescue branch 2 times, most recently from d61c998 to 971f759 Compare January 8, 2024 16:02
@bchamagne bchamagne force-pushed the listener-protocol-rescue branch from 971f759 to 90868f3 Compare January 8, 2024 16:27
@samuelmanzanera samuelmanzanera merged commit c85f454 into archethic-foundation:develop Jan 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmanzanera samuelmanzanera samuelmanzanera approved these changes

@Neylix Neylix Neylix approved these changes

Assignees
No one assigned
Labels
bug Something isn't working P2P Involve P2P networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bchamagne @samuelmanzanera @Neylix