-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geopatch to node transactions #1605
Open
wassimans
wants to merge
2
commits into
archethic-foundation:develop
Choose a base branch
from
wassimans:feature/add-geopatch-in-node-transaction
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add geopatch to node transactions #1605
wassimans
wants to merge
2
commits into
archethic-foundation:develop
from
wassimans:feature/add-geopatch-in-node-transaction
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98184eb
to
923859f
Compare
Neylix
requested changes
Nov 27, 2024
priv/migration_tasks/prod/1.5.14@add_geopatch_node_transactiosn.ex
Outdated
Show resolved
Hide resolved
priv/migration_tasks/prod/1.5.14@add_geopatch_node_transactiosn.ex
Outdated
Show resolved
Hide resolved
priv/migration_tasks/prod/1.5.14@add_geopatch_node_transactiosn.ex
Outdated
Show resolved
Hide resolved
priv/migration_tasks/prod/1.5.14@add_geopatch_node_transactiosn.ex
Outdated
Show resolved
Hide resolved
priv/migration_tasks/prod/1.5.14@add_geopatch_node_transactiosn.ex
Outdated
Show resolved
Hide resolved
923859f
to
5c8b269
Compare
5c8b269
to
57be8b7
Compare
Neylix
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the systematic addition of a geopatch to node transactions. This change ensures that the geopatch is included in node transactions and validated during the transaction lifecycle.
The update impacts the election of storage and validation nodes, as it now relies on the validated geopatch from node transactions rather than local calculations. This approach resolves inconsistencies caused by potential updates to the MMDB2 database.
This change introduces:
• The inclusion of the geopatch in node transactions.
• Migration script to add the geopatch to existing nodes transactions.
• Updated tests to validate the geopatch functionality.
• Enhanced core modules for encoding, decoding, and validating geopatches.
Fixes #1576 #1613
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Functional Tests
Unit Tests
Checklist: