Skip to content

Conversation

@lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Apr 1, 2025

See also architect/sandbox#737.

Thank you for helping out! ✨

We really appreciate your commitment to improving Architect

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • Forked the repo and created your branch from main
  • Made sure tests pass (run npm it from the repo root)
  • Expanded test coverage related to your changes:
    • Added and/or updated unit tests (if appropriate)
    • Added and/or updated integration tests (if appropriate)
  • Updated relevant documentation:
  • Summarized your changes in changelog.md
  • Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

Please also be sure to completed the CLA (if you haven't already).

Learn more about contributing to Architect here.

Thanks again!

@lpsinger
Copy link
Contributor Author

Would someone please review this?

@filmaj filmaj merged commit 6179b18 into architect:main Apr 22, 2025
14 checks passed
@lpsinger lpsinger deleted the access-keys-underscores branch April 22, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants