Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing deprecated code #308

Merged
merged 8 commits into from
Dec 25, 2023
Merged

chore: removing deprecated code #308

merged 8 commits into from
Dec 25, 2023

Conversation

pcarmo
Copy link
Contributor

@pcarmo pcarmo commented Jun 21, 2022

Removed deprecated code from multiple open issues in the same pull request because the changes were simple:

Removed deprecated MessageCorrelationInfoEnricher in pump namespace.
Closes #300.

Removed ObjectExtensions from Arcus.Messaging.ServiceBus.Core since the extension class got empty.
Closes #296.

Removed CanProcessMessage<> method from MessageHandler in the Arcus.Messaging.Abstractions.
Closes #297.

pcarmo added 4 commits June 21, 2022 21:17
…geHandler in the Arcus.Messaging.Abstractions project - issue #297
…instance in the Arcus.Messaging.ServiceBus.Core project - issue #296
…y after removing AsServiceBusMessage deprecated method - related to issue #296
@netlify
Copy link

netlify bot commented Jun 21, 2022

Deploy Preview for arcus-messaging canceled.

Name Link
🔨 Latest commit 74ce542
🔍 Latest deploy log https://app.netlify.com/sites/arcus-messaging/deploys/6589189bd7cf6f0008a933f1

@pcarmo pcarmo closed this Jun 21, 2022
@pcarmo pcarmo reopened this Jun 21, 2022
@stijnmoreels
Copy link
Member

Hi @pcarmo , same as with #307 , we can't continue with this as this is not being assigned to you.
Thx for your enthusiasm!

@stijnmoreels stijnmoreels changed the title Chore: removing deprecated code Chore: removing deprecated code (🚧) Jun 22, 2022
@stijnmoreels stijnmoreels marked this pull request as draft June 22, 2022 05:00
@stijnmoreels stijnmoreels changed the title Chore: removing deprecated code (🚧) chore: removing deprecated code (🚧) Jun 22, 2022
@stijnmoreels stijnmoreels self-assigned this Dec 25, 2023
@stijnmoreels stijnmoreels changed the title chore: removing deprecated code (🚧) chore: removing deprecated code Dec 25, 2023
@stijnmoreels stijnmoreels marked this pull request as ready for review December 25, 2023 05:53
@stijnmoreels
Copy link
Member

/azp run CI - Arcus.Messaging

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now we can use this again. Thx!

@stijnmoreels stijnmoreels merged commit 23c58b6 into arcus-azure:main Dec 25, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants