Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(remove): event-hubs pump project #476

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stijnmoreels
Copy link
Member

The Messaging library previously supported both Service bus and Event Hubs as message pumps. Due to maintainence costs, and the sheldom usage of message handling in event-sourcing systems, the maintainence cost for this is too high.

Related to the exercise described here #470 , this PR removes the Event Hubs message pump and related feature documentation. This can still be done in a minor release, as separate projects means separate NuGet packages. We only have to archive the NuGet package once we're finished with the release.

@stijnmoreels stijnmoreels added integration:event-hubs All issues concerning integration with Azure Event Hubs message-pumps All issues related to message pumps labels Feb 13, 2025
Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for arcus-messaging ready!

Name Link
🔨 Latest commit 3c84f90
🔍 Latest deploy log https://app.netlify.com/sites/arcus-messaging/deploys/67ad88e6a114cd0008885305
😎 Deploy Preview https://deploy-preview-476--arcus-messaging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stijnmoreels stijnmoreels marked this pull request as ready for review February 13, 2025 06:17
Copy link
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if we shouldn't first deprecate before removing ?
We can have an offline chat on that.

Not necessary, I see since it's in a separate project we can just do that.

@fgheysels
Copy link
Member

I still think it's a pity to remove this pump though.
I wonder if the maintenance cost is that high ? We might not use it very much atm, but I do see use-cases. (Could've used it in the past in one of our projects f.i.)

@stijnmoreels
Copy link
Member Author

I still think it's a pity to remove this pump though. I wonder if the maintenance cost is that high ? We might not use it very much atm, but I do see use-cases. (Could've used it in the past in one of our projects f.i.)

This is only one project of four related to EventHubs. Wanted to do this in steps.
Yes, I believe with the current budget and people, this is rather high maintenance as we don’t even have time to fully upgrade Service bus-related projects. And taking OpenTelemetry into account, there will be much migration/backwards-compatibility needed there, too.

And since this is mostly falling on my shoulders, I don’t believe I have the necessary space to do that all by myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:event-hubs All issues concerning integration with Azure Event Hubs message-pumps All issues related to message pumps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants