-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(remove): event-hubs pump project #476
base: main
Are you sure you want to change the base?
chore(remove): event-hubs pump project #476
Conversation
✅ Deploy Preview for arcus-messaging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if we shouldn't first deprecate before removing ?
We can have an offline chat on that.
Not necessary, I see since it's in a separate project we can just do that.
I still think it's a pity to remove this pump though. |
This is only one project of four related to EventHubs. Wanted to do this in steps. And since this is mostly falling on my shoulders, I don’t believe I have the necessary space to do that all by myself. |
The Messaging library previously supported both Service bus and Event Hubs as message pumps. Due to maintainence costs, and the sheldom usage of message handling in event-sourcing systems, the maintainence cost for this is too high.
Related to the exercise described here #470 , this PR removes the Event Hubs message pump and related feature documentation. This can still be done in a minor release, as separate projects means separate NuGet packages. We only have to archive the NuGet package once we're finished with the release.