Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service-bus): remove invalid flags attribute on topic subscription #483

Conversation

stijnmoreels
Copy link
Member

The TopicSubscription invalidly had the [Flags] attribute, which would indicate that the enumeration members could be used in combination with one another - which is not correct.

This PR removes the [Flags] attribute, making the intend of the enumeration more clear.

@stijnmoreels stijnmoreels added the integration:service-bus All issues concerning integration with Azure Service Bus label Feb 13, 2025
Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for arcus-messaging canceled.

Name Link
🔨 Latest commit b9c2427
🔍 Latest deploy log https://app.netlify.com/sites/arcus-messaging/deploys/67ad97b15865520008cc38ed

@stijnmoreels stijnmoreels marked this pull request as ready for review February 13, 2025 07:12
Copy link
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@fgheysels fgheysels merged commit d7e10cd into arcus-azure:main Feb 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:service-bus All issues concerning integration with Azure Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants