Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sb): deprecate older rotate connection strings functionality #495

Conversation

stijnmoreels
Copy link
Member

Deprecates the functionality in the Service bus pump project that allows for rotation of conection strings. This used an older version of authentication, and is somewhat conflicting with the 'pump' project as it has little to do with message routing.

This PR deprecates all rotation-related functionality.

@stijnmoreels stijnmoreels added management All issues related to management of the project integration:service-bus All issues concerning integration with Azure Service Bus labels Feb 25, 2025
Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for arcus-messaging canceled.

Name Link
🔨 Latest commit 01c9369
🔍 Latest deploy log https://app.netlify.com/sites/arcus-messaging/deploys/67bd747c2d30960008cc4082

@fgheysels
Copy link
Member

I didn't even know this functionality existed in Arcus.Messaging.
TBH, I also think that this kind of functionality should not be the responsibility of Arcus.Messaging. This is more an 'infra/devops' or 'operations-like' task. I don't think you want a program that is responsible for consuming / processing messages be responsible for things like this.

IMHO, a good thing to have it removed.

@fgheysels fgheysels merged commit 2543013 into arcus-azure:main Feb 25, 2025
14 checks passed
@stijnmoreels stijnmoreels deleted the chore/deprecate-older-rotate-connection-strings-functionality branch February 25, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:service-bus All issues concerning integration with Azure Service Bus management All issues related to management of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants