Resolve GitHub repo slug dynamically & add workflow artifact options#95
Open
cdavis-code wants to merge 1 commit into
Open
Resolve GitHub repo slug dynamically & add workflow artifact options#95cdavis-code wants to merge 1 commit into
cdavis-code wants to merge 1 commit into
Conversation
- Replace hardcoded repository slug defaults with git remote parsing in cache.dart, avoiding silent artifact fetches from the wrong repo - Add --github-artifacts-runid and --github-artifacts-repo options to flutterpi_tool build for downloading engine binaries from GitHub Actions workflow runs - Parse workflow args early in context initialization to support cache creation from CLI flags - Fix URL encoding in getReleaseByTagName for tags with special chars - Fix artifact total count parsing when GitHub API returns non-integer - Bump version to 0.13.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces hardcoded GitHub repository slug defaults with dynamic resolution from the local git remote, and adds support for downloading engine artifacts from GitHub Actions workflow runs.
Changes
Dynamic repository resolution
lib/src/cache.dart: Add_resolveRepoSlugFromGit()helper that parses the git remote URL to determine the owner/repo dynamically. This replaces hardcodedgh.RepositorySlug('ardera', 'flutter-ci')defaults inGithubWorkflowRunArtifact,GithubReleaseArtifact, andFlutterpiCacheWithFlutterArtifactsfactories.--github-artifacts-repo.GitHub workflow artifact options
lib/src/cli/commands/build.dart: Add--github-artifacts-runidand--github-artifacts-repooptions (hidden behind--verbose) for downloading engine binaries from specific GitHub Actions workflow runs.lib/src/context.dart: Parse workflow args early in context initialization to support cache creation from CLI flags.lib/src/executable.dart: Store raw command-line args before context initialization.Bug fixes
lib/src/github.dart: URL-encode tag names ingetReleaseByTagNameto handle tags with special characters (e.g.,engine/abc123).lib/src/github.dart: Fix artifact total count parsing when GitHub API returns non-integer values fortotal_count.Version bump
pubspec.yamlCHANGELOG.mdVerification
dart analyzereports no errors.