Deferred OTA #281

pennam · 2021-10-20T14:13:40Z

@facchinm i've took your PR #265 and made some small changes:

removed default transport overriding
Added bfe9e1c 00f61ba in order to sync _ota_req variable with the cloud and be able to start a deferred OTA after a board reset.
some other minor cosmetic change

Having this feature has some minor drawbacks:

last_values message size is increased
if for some reason the library fails to send the cleared _ota_req flag to the cloud then onOTARequestCb() will be called again even if the OTA update was already applied.

Tests:

WebIDE OTA:

Board	Test
MKR WiFi 1010	✔️
Portenta	✔️
NANO RP2040	✔️

arduino-cloud-cli deferred OTA:

./arduino-cloud-cli ota upload --device-id xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx --file filename.ino.bin --deferred

Board	Test
MKR WiFi 1010	✔️
Portenta	✔️
NANO RP2040	✔️

/cc @eclipse1985 @manchoz

github-actions · 2021-10-20T15:50:06Z

Memory usage change @ c7945c6

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	🔺 0 - +64	0.0 - +0.01	🔺 +8 - +8	0.0 - 0.0
arduino:mbed:envie_m7	🔺 0 - +64	0.0 - +0.01	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	🔺 +8 - +8	0.0 - 0.0	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrgsm1400	🔺 +48 - +64	+0.02 - +0.02	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	🔺 +8 - +8	0.0 - 0.0	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +64	0.0 - +0.02	🔺 0 - +8	0.0 - +0.02
arduino:samd:nano_33_iot	🔺 0 - +64	0.0 - +0.02	🔺 0 - +8	0.0 - +0.02
esp32:esp32:esp32	🔺 +4 - +8	0.0 - 0.0	🔺 0 - +8	0.0 - 0.0
esp8266:esp8266:huzzah	🔺 0 - +16	0.0 - 0.0	🔺 0 - +16	0.0 - +0.02

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/ArduinoIoTCloud-Basic RAM for global variables	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/ArduinoIoTCloud_Travis_CI RAM for global variables	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	64	0.01	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0
arduino:mbed:envie_m7	64	0.01	0	0.0	64	0.01	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_nano:nanorp2040connect	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02
arduino:samd:mkrgsm1400	48	0.02	0	0.0	64	0.02	0	0.0	48	0.02	0	0.0	48	0.02	0	0.0
arduino:samd:mkrnb1500	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwifi1010	48	0.02	8	0.02	64	0.02	0	0.0	48	0.02	0	0.0	48	0.02	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	48	0.02	8	0.02	64	0.02	0	0.0	48	0.02	0	0.0	48	0.02	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	4	0.0	0	0.0	4	0.0	8	0.0	8	0.0	8	0.0
esp8266:esp8266:huzzah	0	0.0	16	0.02	0	0.0	0	0.0	16	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,64,0.01,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0
arduino:mbed:envie_m7,64,0.01,0,0.0,64,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,,,,
arduino:samd:mkrgsm1400,48,0.02,0,0.0,64,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,,,,
arduino:samd:mkrnb1500,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,48,0.02,8,0.02,64,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,48,0.02,8,0.02,64,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,4,0.0,0,0.0,4,0.0,8,0.0,8,0.0,8,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,16,0.02,0,0.0,0,0.0,16,0.0,0,0.0,,,,,,,,

codecov-commenter · 2021-10-22T11:47:26Z

Codecov Report

Merging #281 (93bb40a) into master (5e19f33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          25       25           
  Lines         896      896           
=======================================
  Hits          854      854           
  Misses         42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd906d9...93bb40a. Read the comment docs.

github-actions · 2021-10-22T12:24:12Z

Memory usage change @ 5436c05

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	🔺 0 - +64	0.0 - +0.01	🔺 +8 - +8	0.0 - 0.0
arduino:mbed:envie_m7	🔺 +96 - +160	+0.01 - +0.02	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	🔺 +8 - +8	0.0 - 0.0	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrgsm1400	🔺 +152 - +168	+0.06 - +0.06	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	🔺 +8 - +8	0.0 - 0.0	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +136	0.0 - +0.05	🔺 0 - +8	0.0 - +0.02
arduino:samd:nano_33_iot	🔺 0 - +136	0.0 - +0.05	🔺 0 - +8	0.0 - +0.02
esp32:esp32:esp32	🔺 +4 - +8	0.0 - 0.0	🔺 0 - +8	0.0 - 0.0
esp8266:esp8266:huzzah	🔺 0 - +16	0.0 - 0.0	🔺 0 - +16	0.0 - +0.02

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/ArduinoIoTCloud-Basic RAM for global variables	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/ArduinoIoTCloud_Travis_CI RAM for global variables	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	64	0.01	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0
arduino:mbed:envie_m7	160	0.02	0	0.0	160	0.02	0	0.0	96	0.01	0	0.0	96	0.01	0	0.0
arduino:mbed_nano:nanorp2040connect	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02
arduino:samd:mkrgsm1400	152	0.06	0	0.0	168	0.06	0	0.0	152	0.06	0	0.0	152	0.06	0	0.0
arduino:samd:mkrnb1500	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwifi1010	120	0.05	8	0.02	136	0.05	0	0.0	128	0.05	0	0.0	120	0.05	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	120	0.05	8	0.02	136	0.05	0	0.0	128	0.05	0	0.0	120	0.05	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	4	0.0	0	0.0	4	0.0	8	0.0	8	0.0	8	0.0
esp8266:esp8266:huzzah	0	0.0	16	0.02	0	0.0	0	0.0	16	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,64,0.01,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0
arduino:mbed:envie_m7,160,0.02,0,0.0,160,0.02,0,0.0,96,0.01,0,0.0,96,0.01,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,,,,
arduino:samd:mkrgsm1400,152,0.06,0,0.0,168,0.06,0,0.0,152,0.06,0,0.0,152,0.06,0,0.0,,,,
arduino:samd:mkrnb1500,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,120,0.05,8,0.02,136,0.05,0,0.0,128,0.05,0,0.0,120,0.05,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,120,0.05,8,0.02,136,0.05,0,0.0,128,0.05,0,0.0,120,0.05,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,4,0.0,0,0.0,4,0.0,8,0.0,8,0.0,8,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,16,0.02,0,0.0,0,0.0,16,0.0,0,0.0,,,,,,,,

pennam · 2021-10-25T07:11:33Z

Sending back to the cloud the cleared _ota_req right after receiving it is not working because it does not respect the minimum time between updates

ArduinoIoTCloud/src/property/Property.h

Line 216 in 5e19f33

    
           static unsigned long const DEFAULT_MIN_TIME_BETWEEN_UPDATES_MILLIS = 500; /* Data rate throttled to 2 Hz */

. To solve this i've removed the system reset from the onOTARequest() function to clear the _ota_req after it and then added a dedicated function to reset the board.

github-actions · 2021-10-25T08:13:42Z

Memory usage change @ e4ce494

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	🔺 0 - +64	0.0 - +0.01	🔺 +8 - +8	0.0 - 0.0
arduino:mbed:envie_m7	🔺 +160 - +224	+0.02 - +0.03	🔺 +8 - +8	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	🔺 0 - +8	0.0 - 0.0
arduino:samd:mkr1000	🔺 +8 - +8	0.0 - 0.0	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrgsm1400	🔺 +216 - +232	+0.08 - +0.09	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrnb1500	🔺 +8 - +8	0.0 - 0.0	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +208	0.0 - +0.08	🔺 0 - +16	0.0 - +0.05
arduino:samd:nano_33_iot	🔺 0 - +208	0.0 - +0.08	🔺 0 - +16	0.0 - +0.05
esp32:esp32:esp32	🔺 +4 - +8	0.0 - 0.0	🔺 0 - +8	0.0 - 0.0
esp8266:esp8266:huzzah	🔺 0 - +16	0.0 - 0.0	🔺 0 - +16	0.0 - +0.02

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/ArduinoIoTCloud-Basic RAM for global variables	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/ArduinoIoTCloud_Travis_CI RAM for global variables	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	64	0.01	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0
arduino:mbed:envie_m7	224	0.03	8	0.0	224	0.03	8	0.0	224	0.03	8	0.0	160	0.02	8	0.0
arduino:mbed_nano:nanorp2040connect	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02
arduino:samd:mkrgsm1400	216	0.08	8	0.02	232	0.09	8	0.02	216	0.08	8	0.02	216	0.08	8	0.02
arduino:samd:mkrnb1500	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwifi1010	192	0.07	16	0.05	208	0.08	8	0.02	192	0.07	8	0.02	192	0.07	8	0.02	0	0.0	0	0.0
arduino:samd:nano_33_iot	192	0.07	16	0.05	208	0.08	8	0.02	192	0.07	8	0.02	184	0.07	8	0.02	0	0.0	0	0.0
esp32:esp32:esp32	4	0.0	0	0.0	4	0.0	8	0.0	8	0.0	8	0.0
esp8266:esp8266:huzzah	0	0.0	16	0.02	0	0.0	0	0.0	16	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,64,0.01,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0
arduino:mbed:envie_m7,224,0.03,8,0.0,224,0.03,8,0.0,224,0.03,8,0.0,160,0.02,8,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,,,,
arduino:samd:mkrgsm1400,216,0.08,8,0.02,232,0.09,8,0.02,216,0.08,8,0.02,216,0.08,8,0.02,,,,
arduino:samd:mkrnb1500,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,192,0.07,16,0.05,208,0.08,8,0.02,192,0.07,8,0.02,192,0.07,8,0.02,0,0.0,0,0.0
arduino:samd:nano_33_iot,192,0.07,16,0.05,208,0.08,8,0.02,192,0.07,8,0.02,184,0.07,8,0.02,0,0.0,0,0.0
esp32:esp32:esp32,4,0.0,0,0.0,4,0.0,8,0.0,8,0.0,8,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,16,0.02,0,0.0,0,0.0,16,0.0,0,0.0,,,,,,,,

pennam · 2021-10-25T16:08:02Z

Force pushed because i've found an easier solution

github-actions · 2021-10-25T17:02:05Z

Memory usage change @ 9cf7523

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	🔺 0 - +64	0.0 - +0.01	🔺 +8 - +8	0.0 - 0.0
arduino:mbed:envie_m7	🔺 0 - +64	0.0 - +0.01	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	🔺 +48 - +64	+0.02 - +0.02	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	🔺 +8 - +8	0.0 - 0.0	🔺 +8 - +8	+0.02 - +0.02
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +64	0.0 - +0.02	🔺 0 - +8	0.0 - +0.02
arduino:samd:nano_33_iot	🔺 0 - +64	0.0 - +0.02	🔺 0 - +8	0.0 - +0.02
esp32:esp32:esp32	🔺 +4 - +8	0.0 - 0.0	🔺 0 - +8	0.0 - 0.0
esp8266:esp8266:huzzah	🔺 0 - +16	0.0 - 0.0	🔺 0 - +16	0.0 - +0.02

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/ArduinoIoTCloud-Basic RAM for global variables	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/ArduinoIoTCloud_Travis_CI RAM for global variables	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	64	0.01	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0
arduino:mbed:envie_m7	64	0.01	0	0.0	64	0.01	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_nano:nanorp2040connect	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrgsm1400	48	0.02	0	0.0	64	0.02	0	0.0	48	0.02	0	0.0	48	0.02	0	0.0
arduino:samd:mkrnb1500	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02	8	0.0	8	0.02
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwifi1010	48	0.02	8	0.02	64	0.02	0	0.0	48	0.02	0	0.0	48	0.02	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	48	0.02	8	0.02	64	0.02	0	0.0	48	0.02	0	0.0	48	0.02	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	4	0.0	0	0.0	4	0.0	8	0.0	8	0.0	8	0.0
esp8266:esp8266:huzzah	0	0.0	16	0.02	0	0.0	0	0.0	16	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,64,0.01,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0
arduino:mbed:envie_m7,64,0.01,0,0.0,64,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,48,0.02,0,0.0,64,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,,,,
arduino:samd:mkrnb1500,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,48,0.02,8,0.02,64,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,48,0.02,8,0.02,64,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,4,0.0,0,0.0,4,0.0,8,0.0,8,0.0,8,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,16,0.02,0,0.0,0,0.0,16,0.0,0,0.0,,,,,,,,

aentinger

LGTM 👍 A couple of suggestions concerning naming and overall code consistency.

examples/ArduinoIoTCloud-DeferredOTA/ArduinoIoTCloud-DeferredOTA.ino

src/ArduinoIoTCloudTCP.cpp

src/ArduinoIoTCloudTCP.h

pennam · 2021-10-27T08:38:30Z

Thanks @aentinger i will definitely implement your suggestions to avoid code style mish mash and improve clarity.

github-actions · 2021-10-27T13:00:56Z

Memory usage change @ 9ac60f8

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed:envie_m7	🔺 0 - +64	0.0 - +0.01	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	🔺 +48 - +64	+0.02 - +0.02	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +56	0.0 - +0.02	🔺 0 - +8	0.0 - +0.02
arduino:samd:nano_33_iot	🔺 0 - +56	0.0 - +0.02	🔺 0 - +8	0.0 - +0.02
esp32:esp32:esp32	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed:envie_m7	64	0.01	0	0.0	64	0.01	0	0.0	0	0.0	0	0.0
arduino:mbed_nano:nanorp2040connect	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrgsm1400	48	0.02	0	0.0	64	0.02	48	0.02	48	0.02	0	0.0
arduino:samd:mkrnb1500	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwifi1010	40	0.02	8	0.02	56	0.02	48	0.02	48	0.02	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	40	0.02	8	0.02	56	0.02	48	0.02	40	0.02	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	0	0.0	0	0.0	0	0.0	0	0.0
esp8266:esp8266:huzzah	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,64,0.01,0,0.0,64,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,48,0.02,0,0.0,64,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,,,,
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,40,0.02,8,0.02,56,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,40,0.02,8,0.02,56,0.02,0,0.0,48,0.02,0,0.0,40,0.02,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,

aentinger

LGTM 👍 Thank you for your changes 👍

… updates check and fail to update the cloud

… run OTA update

pennam · 2021-11-04T12:22:27Z

rebased on master

pennam force-pushed the deferred_ota branch from 8ea7060 to c7945c6 Compare October 20, 2021 14:21

pennam force-pushed the deferred_ota branch from e4ce494 to 9cf7523 Compare October 25, 2021 16:02

pennam requested a review from aentinger October 26, 2021 07:51

aentinger suggested changes Oct 27, 2021

View reviewed changes

pennam requested a review from aentinger October 27, 2021 13:06

aentinger approved these changes Oct 28, 2021

View reviewed changes

facchinm and others added 10 commits November 4, 2021 13:10

Add hook for OTA confirmation

b9bf84d

Add example for Deferred OTA

9938936

Change sync strategy to CLOUD_WINS

29417af

Send cleared _ota_req to cloud to avoid recurring requests

1be9414

Add example information

f650739

Handle _ota_req flag first to avoid running into minimum time between…

18f84ec

… updates check and fail to update the cloud

Use more meaningful name for _automatic_ota and clarify conditions to…

6e9113c

… run OTA update

Initialize _get_ota_confirmation within constructor and chage type name

00a2f6b

Clarify onOTARequestCb usage in the example sketch

6f51148

Add missing channelMask parameter for LoraConnectionHandler

93bb40a

pennam force-pushed the deferred_ota branch from 9ac60f8 to 93bb40a Compare November 4, 2021 12:21

pennam merged commit ab0af75 into arduino-libraries:master Nov 4, 2021

per1234 added the topic: code Related to content of the project itself label Jan 15, 2022

pennam deleted the deferred_ota branch May 17, 2024 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deferred OTA #281

Deferred OTA #281

pennam commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021

codecov-commenter commented Oct 22, 2021 •

edited

Loading

github-actions bot commented Oct 22, 2021

pennam commented Oct 25, 2021

github-actions bot commented Oct 25, 2021

pennam commented Oct 25, 2021

github-actions bot commented Oct 25, 2021

aentinger left a comment

pennam commented Oct 27, 2021

github-actions bot commented Oct 27, 2021

aentinger left a comment

pennam commented Nov 4, 2021

Deferred OTA #281

Deferred OTA #281

Conversation

pennam commented Oct 20, 2021 • edited Loading

github-actions bot commented Oct 20, 2021

codecov-commenter commented Oct 22, 2021 • edited Loading

Codecov Report

github-actions bot commented Oct 22, 2021

pennam commented Oct 25, 2021

github-actions bot commented Oct 25, 2021

pennam commented Oct 25, 2021

github-actions bot commented Oct 25, 2021

aentinger left a comment

Choose a reason for hiding this comment

pennam commented Oct 27, 2021

github-actions bot commented Oct 27, 2021

aentinger left a comment

Choose a reason for hiding this comment

pennam commented Nov 4, 2021

pennam commented Oct 20, 2021 •

edited

Loading

codecov-commenter commented Oct 22, 2021 •

edited

Loading