-
Notifications
You must be signed in to change notification settings - Fork 37
Connectionhandler redesign of internal structures #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andreagilardoni
wants to merge
10
commits into
arduino-libraries:master
Choose a base branch
from
andreagilardoni:connectionhandler-settings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Connectionhandler redesign of internal structures #136
andreagilardoni
wants to merge
10
commits into
arduino-libraries:master
from
andreagilardoni:connectionhandler-settings
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ 0ca6d61
Click for full report table
Click for full report CSV
|
Memory usage change @ 6fbe6b6
Click for full report table
Click for full report CSV
|
5f9c616
to
f4fd222
Compare
Memory usage change @ f4fd222
Click for full report table
Click for full report CSV
|
Memory usage change @ be61e43
Click for full report table
Click for full report CSV
|
be61e43
to
f674482
Compare
…emoving redundant constructor with strings
f674482
to
9dc0fe5
Compare
Memory usage change @ 9dc0fe5
Click for full report table
Click for full report CSV
|
9dc0fe5
to
f34627d
Compare
Memory usage change @ f34627d
Click for full report table
Click for full report CSV
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this PR is to make the implementation of the various connection handler more generic.
with this change it was possible to create a GenericConnection handler that is able to be instantiated in conditions where the kind of connection has to be decided at runtime.
Testing connection handler
mbed core f7ff4114bc0d89f23b45423e049f5bc17114dcbc
renesas core 84d44b8f42bb657d66aa8fdda66f789f294dfddd
samd core 993398cb7a23a4e0f821a73501ae98053773165b