Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

Refactor RS485 support #58

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

manchoz
Copy link
Collaborator

@manchoz manchoz commented Jun 15, 2021

Refactor the RS485 support to be compatible with the ArduinoRS485 library and ArduinoRS485-based tools and libraries (e.g. Arduino Modbus).

Please, review @facchinm @Rocketct

@manchoz
Copy link
Collaborator Author

manchoz commented Jun 16, 2021

Compile Examples CI is failing because this branch needs ArduinoRS485 from upstream (in particular of PR arduino-libraries/ArduinoRS485#6)

@facchinm
Copy link
Collaborator

@manchoz should we release ArduinoRS485 and then merge this one?

@github-actions
Copy link

Memory usage change @ 5aa45e3

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 💚 -128 - 0 -0.02 - 0.0 💚 -104 - 0 -0.02 - 0.0
Click for full report table
Board examples/Analog_Out
flash
% examples/Analog_Out
RAM for global variables
% examples/Analog_input/Analog_input_0_10V
flash
% examples/Analog_input/Analog_input_0_10V
RAM for global variables
% examples/Analog_input/Analog_input_4_20mA
flash
% examples/Analog_input/Analog_input_4_20mA
RAM for global variables
% examples/Analog_input/Analog_input_NTC
flash
% examples/Analog_input/Analog_input_NTC
RAM for global variables
% examples/CAN/ReadCan
flash
% examples/CAN/ReadCan
RAM for global variables
% examples/CAN/WriteCan
flash
% examples/CAN/WriteCan
RAM for global variables
% examples/Digital_output
flash
% examples/Digital_output
RAM for global variables
% examples/Digital_programmable/CombinedIOExpander
flash
% examples/Digital_programmable/CombinedIOExpander
RAM for global variables
% examples/Digital_programmable/Digital_input
flash
% examples/Digital_programmable/Digital_input
RAM for global variables
% examples/Digital_programmable/GPIO_programmable
flash
% examples/Digital_programmable/GPIO_programmable
RAM for global variables
% examples/Encoders
flash
% examples/Encoders
RAM for global variables
% examples/Ethernet
flash
% examples/Ethernet
RAM for global variables
% examples/RS485_fullduplex
flash
% examples/RS485_fullduplex
RAM for global variables
% examples/RS485_halfduplex
flash
% examples/RS485_halfduplex
RAM for global variables
% examples/RTC
flash
% examples/RTC
RAM for global variables
% examples/RTC_Alarm
flash
% examples/RTC_Alarm
RAM for global variables
% examples/Temp_probes_RTD
flash
% examples/Temp_probes_RTD
RAM for global variables
% examples/Temp_probes_Thermocouples
flash
% examples/Temp_probes_Thermocouples
RAM for global variables
% examples/USB_host
flash
% examples/USB_host
RAM for global variables
%
arduino:mbed_portenta:envie_m7 -64 -0.01 -96 -0.02 -128 -0.02 -96 -0.02 -128 -0.02 -96 -0.02 -64 -0.01 -96 -0.02 -128 -0.02 -96 -0.02 -128 -0.02 -96 -0.02 -64 -0.01 -96 -0.02 -128 -0.02 -96 -0.02 -64 -0.01 -104 -0.02 -64 -0.01 -96 -0.02 -64 -0.01 -96 -0.02 0 0.0 0 0.0 -64 -0.01 -96 -0.02 N/A N/A N/A N/A -128 -0.02 -96 -0.02 -128 -0.02 -104 -0.02 -64 -0.01 -96 -0.02 -128 -0.02 -96 -0.02 -128 -0.02 -96 -0.02
Click for full report CSV
Board,examples/Analog_Out<br>flash,%,examples/Analog_Out<br>RAM for global variables,%,examples/Analog_input/Analog_input_0_10V<br>flash,%,examples/Analog_input/Analog_input_0_10V<br>RAM for global variables,%,examples/Analog_input/Analog_input_4_20mA<br>flash,%,examples/Analog_input/Analog_input_4_20mA<br>RAM for global variables,%,examples/Analog_input/Analog_input_NTC<br>flash,%,examples/Analog_input/Analog_input_NTC<br>RAM for global variables,%,examples/CAN/ReadCan<br>flash,%,examples/CAN/ReadCan<br>RAM for global variables,%,examples/CAN/WriteCan<br>flash,%,examples/CAN/WriteCan<br>RAM for global variables,%,examples/Digital_output<br>flash,%,examples/Digital_output<br>RAM for global variables,%,examples/Digital_programmable/CombinedIOExpander<br>flash,%,examples/Digital_programmable/CombinedIOExpander<br>RAM for global variables,%,examples/Digital_programmable/Digital_input<br>flash,%,examples/Digital_programmable/Digital_input<br>RAM for global variables,%,examples/Digital_programmable/GPIO_programmable<br>flash,%,examples/Digital_programmable/GPIO_programmable<br>RAM for global variables,%,examples/Encoders<br>flash,%,examples/Encoders<br>RAM for global variables,%,examples/Ethernet<br>flash,%,examples/Ethernet<br>RAM for global variables,%,examples/RS485_fullduplex<br>flash,%,examples/RS485_fullduplex<br>RAM for global variables,%,examples/RS485_halfduplex<br>flash,%,examples/RS485_halfduplex<br>RAM for global variables,%,examples/RTC<br>flash,%,examples/RTC<br>RAM for global variables,%,examples/RTC_Alarm<br>flash,%,examples/RTC_Alarm<br>RAM for global variables,%,examples/Temp_probes_RTD<br>flash,%,examples/Temp_probes_RTD<br>RAM for global variables,%,examples/Temp_probes_Thermocouples<br>flash,%,examples/Temp_probes_Thermocouples<br>RAM for global variables,%,examples/USB_host<br>flash,%,examples/USB_host<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,-64,-0.01,-96,-0.02,-128,-0.02,-96,-0.02,-128,-0.02,-96,-0.02,-64,-0.01,-96,-0.02,-128,-0.02,-96,-0.02,-128,-0.02,-96,-0.02,-64,-0.01,-96,-0.02,-128,-0.02,-96,-0.02,-64,-0.01,-104,-0.02,-64,-0.01,-96,-0.02,-64,-0.01,-96,-0.02,0,0.0,0,0.0,-64,-0.01,-96,-0.02,N/A,N/A,N/A,N/A,-128,-0.02,-96,-0.02,-128,-0.02,-104,-0.02,-64,-0.01,-96,-0.02,-128,-0.02,-96,-0.02,-128,-0.02,-96,-0.02

@github-actions
Copy link

Memory usage change @ 9784de7

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 💚 -128 - 0 -0.02 - 0.0 💚 -104 - 0 -0.02 - 0.0
Click for full report table
Board examples/Analog_Out
flash
% examples/Analog_Out
RAM for global variables
% examples/Analog_input/Analog_input_0_10V
flash
% examples/Analog_input/Analog_input_0_10V
RAM for global variables
% examples/Analog_input/Analog_input_4_20mA
flash
% examples/Analog_input/Analog_input_4_20mA
RAM for global variables
% examples/Analog_input/Analog_input_NTC
flash
% examples/Analog_input/Analog_input_NTC
RAM for global variables
% examples/CAN/ReadCan
flash
% examples/CAN/ReadCan
RAM for global variables
% examples/CAN/WriteCan
flash
% examples/CAN/WriteCan
RAM for global variables
% examples/Digital_output
flash
% examples/Digital_output
RAM for global variables
% examples/Digital_programmable/CombinedIOExpander
flash
% examples/Digital_programmable/CombinedIOExpander
RAM for global variables
% examples/Digital_programmable/Digital_input
flash
% examples/Digital_programmable/Digital_input
RAM for global variables
% examples/Digital_programmable/GPIO_programmable
flash
% examples/Digital_programmable/GPIO_programmable
RAM for global variables
% examples/Encoders
flash
% examples/Encoders
RAM for global variables
% examples/Ethernet
flash
% examples/Ethernet
RAM for global variables
% examples/RS485_fullduplex
flash
% examples/RS485_fullduplex
RAM for global variables
% examples/RS485_halfduplex
flash
% examples/RS485_halfduplex
RAM for global variables
% examples/RTC
flash
% examples/RTC
RAM for global variables
% examples/RTC_Alarm
flash
% examples/RTC_Alarm
RAM for global variables
% examples/Temp_probes_RTD
flash
% examples/Temp_probes_RTD
RAM for global variables
% examples/Temp_probes_Thermocouples
flash
% examples/Temp_probes_Thermocouples
RAM for global variables
% examples/USB_host
flash
% examples/USB_host
RAM for global variables
%
arduino:mbed_portenta:envie_m7 -64 -0.01 -96 -0.02 -64 -0.01 -96 -0.02 -64 -0.01 -96 -0.02 -128 -0.02 -96 -0.02 -128 -0.02 -96 -0.02 -64 -0.01 -96 -0.02 -64 -0.01 -96 -0.02 -64 -0.01 -96 -0.02 -64 -0.01 -104 -0.02 -64 -0.01 -96 -0.02 -128 -0.02 -96 -0.02 0 0.0 0 0.0 -64 -0.01 -96 -0.02 N/A N/A N/A N/A -128 -0.02 -96 -0.02 -128 -0.02 -104 -0.02 -128 -0.02 -96 -0.02 -128 -0.02 -96 -0.02 -64 -0.01 -96 -0.02
Click for full report CSV
Board,examples/Analog_Out<br>flash,%,examples/Analog_Out<br>RAM for global variables,%,examples/Analog_input/Analog_input_0_10V<br>flash,%,examples/Analog_input/Analog_input_0_10V<br>RAM for global variables,%,examples/Analog_input/Analog_input_4_20mA<br>flash,%,examples/Analog_input/Analog_input_4_20mA<br>RAM for global variables,%,examples/Analog_input/Analog_input_NTC<br>flash,%,examples/Analog_input/Analog_input_NTC<br>RAM for global variables,%,examples/CAN/ReadCan<br>flash,%,examples/CAN/ReadCan<br>RAM for global variables,%,examples/CAN/WriteCan<br>flash,%,examples/CAN/WriteCan<br>RAM for global variables,%,examples/Digital_output<br>flash,%,examples/Digital_output<br>RAM for global variables,%,examples/Digital_programmable/CombinedIOExpander<br>flash,%,examples/Digital_programmable/CombinedIOExpander<br>RAM for global variables,%,examples/Digital_programmable/Digital_input<br>flash,%,examples/Digital_programmable/Digital_input<br>RAM for global variables,%,examples/Digital_programmable/GPIO_programmable<br>flash,%,examples/Digital_programmable/GPIO_programmable<br>RAM for global variables,%,examples/Encoders<br>flash,%,examples/Encoders<br>RAM for global variables,%,examples/Ethernet<br>flash,%,examples/Ethernet<br>RAM for global variables,%,examples/RS485_fullduplex<br>flash,%,examples/RS485_fullduplex<br>RAM for global variables,%,examples/RS485_halfduplex<br>flash,%,examples/RS485_halfduplex<br>RAM for global variables,%,examples/RTC<br>flash,%,examples/RTC<br>RAM for global variables,%,examples/RTC_Alarm<br>flash,%,examples/RTC_Alarm<br>RAM for global variables,%,examples/Temp_probes_RTD<br>flash,%,examples/Temp_probes_RTD<br>RAM for global variables,%,examples/Temp_probes_Thermocouples<br>flash,%,examples/Temp_probes_Thermocouples<br>RAM for global variables,%,examples/USB_host<br>flash,%,examples/USB_host<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,-64,-0.01,-96,-0.02,-64,-0.01,-96,-0.02,-64,-0.01,-96,-0.02,-128,-0.02,-96,-0.02,-128,-0.02,-96,-0.02,-64,-0.01,-96,-0.02,-64,-0.01,-96,-0.02,-64,-0.01,-96,-0.02,-64,-0.01,-104,-0.02,-64,-0.01,-96,-0.02,-128,-0.02,-96,-0.02,0,0.0,0,0.0,-64,-0.01,-96,-0.02,N/A,N/A,N/A,N/A,-128,-0.02,-96,-0.02,-128,-0.02,-104,-0.02,-128,-0.02,-96,-0.02,-128,-0.02,-96,-0.02,-64,-0.01,-96,-0.02

@aentinger
Copy link
Contributor

@manchoz should we release ArduinoRS485 and then merge this one?

Up 🙃 👍

@manchoz
Copy link
Collaborator Author

manchoz commented Aug 23, 2021

@facchinm with the arduino-libraries/ArduinoRS485#13 merged, ArduinoRS485 is ready to be released and this PR merged.

@manchoz manchoz marked this pull request as ready for review August 23, 2021 12:48
@github-actions
Copy link

Memory usage change @ 078a330

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 💚 -128 - 0 -0.02 - 0.0 💚 -104 - 0 -0.02 - 0.0
Click for full report table
Board examples/Analog_Out
flash
% examples/Analog_Out
RAM for global variables
% examples/Analog_input/Analog_input_0_10V
flash
% examples/Analog_input/Analog_input_0_10V
RAM for global variables
% examples/Analog_input/Analog_input_4_20mA
flash
% examples/Analog_input/Analog_input_4_20mA
RAM for global variables
% examples/Analog_input/Analog_input_NTC
flash
% examples/Analog_input/Analog_input_NTC
RAM for global variables
% examples/CAN/ReadCan
flash
% examples/CAN/ReadCan
RAM for global variables
% examples/CAN/WriteCan
flash
% examples/CAN/WriteCan
RAM for global variables
% examples/Digital_output
flash
% examples/Digital_output
RAM for global variables
% examples/Digital_programmable/CombinedIOExpander
flash
% examples/Digital_programmable/CombinedIOExpander
RAM for global variables
% examples/Digital_programmable/Digital_input
flash
% examples/Digital_programmable/Digital_input
RAM for global variables
% examples/Digital_programmable/GPIO_programmable
flash
% examples/Digital_programmable/GPIO_programmable
RAM for global variables
% examples/Encoders
flash
% examples/Encoders
RAM for global variables
% examples/Ethernet
flash
% examples/Ethernet
RAM for global variables
% examples/RS485_fullduplex
flash
% examples/RS485_fullduplex
RAM for global variables
% examples/RS485_halfduplex
flash
% examples/RS485_halfduplex
RAM for global variables
% examples/RTC
flash
% examples/RTC
RAM for global variables
% examples/RTC_Alarm
flash
% examples/RTC_Alarm
RAM for global variables
% examples/Temp_probes_RTD
flash
% examples/Temp_probes_RTD
RAM for global variables
% examples/Temp_probes_Thermocouples
flash
% examples/Temp_probes_Thermocouples
RAM for global variables
% examples/USB_host
flash
% examples/USB_host
RAM for global variables
%
arduino:mbed_portenta:envie_m7 -128 -0.02 -96 -0.02 -64 -0.01 -96 -0.02 -64 -0.01 -96 -0.02 -128 -0.02 -96 -0.02 -128 -0.02 -96 -0.02 -64 -0.01 -96 -0.02 -64 -0.01 -96 -0.02 -64 -0.01 -96 -0.02 -64 -0.01 -104 -0.02 -64 -0.01 -96 -0.02 -128 -0.02 -96 -0.02 0 0.0 0 0.0 -64 -0.01 -96 -0.02 N/A N/A N/A N/A -128 -0.02 -96 -0.02 -128 -0.02 -104 -0.02 -128 -0.02 -96 -0.02 -128 -0.02 -96 -0.02 -64 -0.01 -96 -0.02
Click for full report CSV
Board,examples/Analog_Out<br>flash,%,examples/Analog_Out<br>RAM for global variables,%,examples/Analog_input/Analog_input_0_10V<br>flash,%,examples/Analog_input/Analog_input_0_10V<br>RAM for global variables,%,examples/Analog_input/Analog_input_4_20mA<br>flash,%,examples/Analog_input/Analog_input_4_20mA<br>RAM for global variables,%,examples/Analog_input/Analog_input_NTC<br>flash,%,examples/Analog_input/Analog_input_NTC<br>RAM for global variables,%,examples/CAN/ReadCan<br>flash,%,examples/CAN/ReadCan<br>RAM for global variables,%,examples/CAN/WriteCan<br>flash,%,examples/CAN/WriteCan<br>RAM for global variables,%,examples/Digital_output<br>flash,%,examples/Digital_output<br>RAM for global variables,%,examples/Digital_programmable/CombinedIOExpander<br>flash,%,examples/Digital_programmable/CombinedIOExpander<br>RAM for global variables,%,examples/Digital_programmable/Digital_input<br>flash,%,examples/Digital_programmable/Digital_input<br>RAM for global variables,%,examples/Digital_programmable/GPIO_programmable<br>flash,%,examples/Digital_programmable/GPIO_programmable<br>RAM for global variables,%,examples/Encoders<br>flash,%,examples/Encoders<br>RAM for global variables,%,examples/Ethernet<br>flash,%,examples/Ethernet<br>RAM for global variables,%,examples/RS485_fullduplex<br>flash,%,examples/RS485_fullduplex<br>RAM for global variables,%,examples/RS485_halfduplex<br>flash,%,examples/RS485_halfduplex<br>RAM for global variables,%,examples/RTC<br>flash,%,examples/RTC<br>RAM for global variables,%,examples/RTC_Alarm<br>flash,%,examples/RTC_Alarm<br>RAM for global variables,%,examples/Temp_probes_RTD<br>flash,%,examples/Temp_probes_RTD<br>RAM for global variables,%,examples/Temp_probes_Thermocouples<br>flash,%,examples/Temp_probes_Thermocouples<br>RAM for global variables,%,examples/USB_host<br>flash,%,examples/USB_host<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,-128,-0.02,-96,-0.02,-64,-0.01,-96,-0.02,-64,-0.01,-96,-0.02,-128,-0.02,-96,-0.02,-128,-0.02,-96,-0.02,-64,-0.01,-96,-0.02,-64,-0.01,-96,-0.02,-64,-0.01,-96,-0.02,-64,-0.01,-104,-0.02,-64,-0.01,-96,-0.02,-128,-0.02,-96,-0.02,0,0.0,0,0.0,-64,-0.01,-96,-0.02,N/A,N/A,N/A,N/A,-128,-0.02,-96,-0.02,-128,-0.02,-104,-0.02,-128,-0.02,-96,-0.02,-128,-0.02,-96,-0.02,-64,-0.01,-96,-0.02

@aentinger aentinger merged commit 305e09e into arduino-libraries:master Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants