Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct readLinearAcceleration function #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Correct readLinearAcceleration function #2

wants to merge 3 commits into from

Conversation

septatrix
Copy link

changed typo to give back correct information like the other methods which read linearAccelData

@septatrix
Corrected readLinearAcceleration
969bccd 
changed typo to give back correct information like the other methods which read linearAccelData
trullock
trullock suggested changes Nov 18, 2019
View reviewed changes
Copy link

@trullock trullock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely looks like a fix to a bug, but its a breaking change so there should be a version increment associated with this

@CLAassistant
Copy link

CLAassistant commented May 16, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@septatrix
Copy link
Author

@arduino-libraries any chance to get this merged?

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels May 20, 2022
per1234
per1234 previously requested changes May 20, 2022
View reviewed changes
@per1234 per1234 dismissed their stale review May 20, 2022 12:47

Requested change has been made. Thanks!

@septatrix
Copy link
Author

septatrix commented Oct 31, 2023 •
edited
Loading

@trullock @per1234

As the library now mentions that it is deprecated, please archive it in github such that this fact is easily visible (and please merge this simple bug fix beforehand)

@septatrix septatrix requested review from per1234 and trullock October 31, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trullock trullock trullock requested changes

@per1234 per1234 per1234 left review comments

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@septatrix @CLAassistant @trullock @per1234